swaybar protocol: handle button 4 and 5 #1368
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the patch!
This isn't going to work - can you fix this? |
|
Yeah, I'm very unfamiliar with the code base atm - just started looking at it today. Should be quite easy to fix I believe. |
i3 bar handles scroll events as button 4 and 5. An example use case would be volume up/down.
johnae
force-pushed
the
swaybar-handle-scroll-events
branch
from
2032c8d
to
feb8bb9
Compare
|
@SirCmpwn There. Much better overall i.m.o and workspace switching should work as before (unless over the status bar items ofc). |
|
Yes, that looks much better, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
i3 bar handles scroll events as button 4 and 5. An example use case would be volume up/down.
This probably has some effect on the "scrolling between workspaces" feature - now one probably has to put the pointer over the workspace buttons for it to work.