Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix move next crash #1130

Merged
merged 2 commits into from
Mar 19, 2017
Merged

Fix move next crash #1130

merged 2 commits into from
Mar 19, 2017

Commits on Mar 19, 2017

  1. The default layout of a workspace should follow the output 

    Hardcoding it to L_HORIZ does not make sense to me,
as you get the unexpected behaviour that windows will be
arranged horizontally until you switch the layout.
    @oranenj
    oranenj committed Mar 19, 2017
    Configuration menu
    Copy the full SHA
    d735091 View commit details
    Browse the repository at this point in the history

  2. Prevent "move next" and "move prev" commands from crashing 

    Fixes swaywm#1120

When the parent of a view is C_WORKSPACE and the movement direction
is either MOVE_PREV or MOVE_NEXT, the code would attempt to move the
views to the next output, but swayc_adjacent_output can't accept
non-directional movement commands and causes undefined behaviour and
a segfault.

If the code is simply skipped, we end up in an infinite loop.

Instead, we can allow containers whose parent is a C_WORKSPACE take the
path that handles MOVE_PREV and MOVE_NEXT, which behaves as you would
expect.

I'm not certain that this fix is entirely correct as the desired behaviour
of move_container is not very well defined, but it seems to work.
    @oranenj
    oranenj committed Mar 19, 2017
    Configuration menu
    Copy the full SHA
    924ed64 View commit details
    Browse the repository at this point in the history