Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added timeout settings for auth request #87

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

variable
Copy link

@variable variable commented Nov 13, 2019

When a node is having network issue, it will wait endlessly for auth request without setting a timeout. This PR will pass the timeout setting to the auth request.

@coveralls
Copy link

coveralls commented Nov 13, 2019

Coverage Status

Coverage increased (+2.0%) to 81.126% when pulling 81b160c on variable:feature/http_auth_timeout into f7874b5 on swayf:develop.

@morph027
Copy link

Would you mind re-creating this PR for https://github.com/proxmoxer/proxmoxer ?

@variable
Copy link
Author

Would you mind re-creating this PR for https://github.com/proxmoxer/proxmoxer ?

here it is proxmoxer/proxmoxer#2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants