Skip to content

Commit

Permalink
test: fix failing tests due to implementation changes
Browse files Browse the repository at this point in the history
  • Loading branch information
swashata committed Apr 26, 2021
1 parent 5123662 commit 3113686
Show file tree
Hide file tree
Showing 4 changed files with 88 additions and 74 deletions.
56 changes: 30 additions & 26 deletions tests/data/dist/app/manifest.json
Original file line number Diff line number Diff line change
Expand Up @@ -10,34 +10,38 @@
"runtime.js.map": "app/runtime.js.map",
"wpackioEp": {
"main": {
"js": [
"app/runtime.js",
"app/vendor.js",
"app/main.js"
],
"js.map": [
"app/runtime.js.map",
"app/vendor.js.map",
"app/main.js.map"
],
"css": [
"app/main.css"
],
"css.map": [
"app/main.css.map"
]
"assets": {
"js": [
"app/runtime.js",
"app/vendor.js",
"app/main.js"
],
"js.map": [
"app/runtime.js.map",
"app/vendor.js.map",
"app/main.js.map"
],
"css": [
"app/main.css"
],
"css.map": [
"app/main.css.map"
]
}
},
"mobile": {
"js": [
"app/runtime.js",
"app/vendor.js",
"app/mobile.js"
],
"js.map": [
"app/runtime.js.map",
"app/vendor.js.map",
"app/mobile.js.map"
]
"assets": {
"js": [
"app/runtime.js",
"app/vendor.js",
"app/mobile.js"
],
"js.map": [
"app/runtime.js.map",
"app/vendor.js.map",
"app/mobile.js.map"
]
}
}
}
}
40 changes: 22 additions & 18 deletions tests/data/dist/broken/manifest.json
Original file line number Diff line number Diff line change
Expand Up @@ -8,26 +8,30 @@
"mobile.js.map": "app/mobile.js.map",
"blablabla": {
"main": {
"css": [
"app/main.css"
],
"js": [
"app/main.js"
],
"css.map": [
"app/main.css.map"
],
"js.map": [
"app/main.js.map"
]
"assets": {
"css": [
"app/main.css"
],
"js": [
"app/main.js"
],
"css.map": [
"app/main.css.map"
],
"js.map": [
"app/main.js.map"
]
}
},
"mobile": {
"js": [
"app/mobile.js"
],
"js.map": [
"app/mobile.js.map"
]
"assets": {
"js": [
"app/mobile.js"
],
"js.map": [
"app/mobile.js.map"
]
}
}
}
}
4 changes: 2 additions & 2 deletions tests/testcases/EnqueueTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -365,15 +365,15 @@ public function test_register() {
$js_deps = [];
$css_deps = [];

foreach ( $manifest['wpackioEp']['main']['js'] as $js_path ) {
foreach ( $manifest['wpackioEp']['main']['assets']['js'] as $js_path ) {
$js_handle = $enqueue->getHandle( 'app', $js_path, 'script' );
\Brain\Monkey\Functions\expect( 'wp_register_script' )
->once()
->with( $js_handle, $this->pu . '/' . $js_path, array_merge( [ 'jquery' ], $js_deps ), '1.0.0', true );
$js_deps[] = $js_handle;
}
// Loop over all css and make sure wp_register_style is called
foreach ( $manifest['wpackioEp']['main']['css'] as $css_path ) {
foreach ( $manifest['wpackioEp']['main']['assets']['css'] as $css_path ) {
$css_handle = $enqueue->getHandle( 'app', $css_path, 'style' );
\Brain\Monkey\Functions\expect( 'wp_register_style' )
->once()
Expand Down
62 changes: 34 additions & 28 deletions tests/testcases/__snapshots__/EnqueueTest__test_getManifest__1.php
Original file line number Diff line number Diff line change
Expand Up @@ -12,40 +12,46 @@
array (
'main' =>
array (
'js' =>
'assets' =>
array (
0 => 'app/runtime.js',
1 => 'app/vendor.js',
2 => 'app/main.js',
),
'js.map' =>
array (
0 => 'app/runtime.js.map',
1 => 'app/vendor.js.map',
2 => 'app/main.js.map',
),
'css' =>
array (
0 => 'app/main.css',
),
'css.map' =>
array (
0 => 'app/main.css.map',
'js' =>
array (
0 => 'app/runtime.js',
1 => 'app/vendor.js',
2 => 'app/main.js',
),
'js.map' =>
array (
0 => 'app/runtime.js.map',
1 => 'app/vendor.js.map',
2 => 'app/main.js.map',
),
'css' =>
array (
0 => 'app/main.css',
),
'css.map' =>
array (
0 => 'app/main.css.map',
),
),
),
'mobile' =>
array (
'js' =>
array (
0 => 'app/runtime.js',
1 => 'app/vendor.js',
2 => 'app/mobile.js',
),
'js.map' =>
'assets' =>
array (
0 => 'app/runtime.js.map',
1 => 'app/vendor.js.map',
2 => 'app/mobile.js.map',
'js' =>
array (
0 => 'app/runtime.js',
1 => 'app/vendor.js',
2 => 'app/mobile.js',
),
'js.map' =>
array (
0 => 'app/runtime.js.map',
1 => 'app/vendor.js.map',
2 => 'app/mobile.js.map',
),
),
),
),
Expand Down

0 comments on commit 3113686

Please sign in to comment.