Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix webpackJsonp and runtime for multiple entry #13

Closed
3 tasks done
swashata opened this issue Oct 20, 2018 · 0 comments
Closed
3 tasks done

Fix webpackJsonp and runtime for multiple entry #13

swashata opened this issue Oct 20, 2018 · 0 comments
Assignees
@swashata
Labels
Priority: Critical Status: In Progress Type: Bug Something isn't working

Comments

@swashata
Copy link
Owner

swashata commented Oct 20, 2018 •
edited
Loading

There could always be multiple entry from same plugin/theme or different plugin/theme. We need a way to handle it.

  • Use an unique output.jsonpFunction so that they don't override each other.
  • Have optimization.runtimeChunk, set to single. This will generate one runtime chunk for all entrypoints.
  • Have PHP load the runtime only once.
@swashata swashata self-assigned this Oct 20, 2018
swashata added a commit that referenced this issue Oct 20, 2018
@swashata
fix: issue with multiple webpackJsonp & runtime
846c2c0 
Now every webpack config will have different webpackJsonp and
there will only be a single runtime.

See #13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@swashata swashata

Labels
Priority: Critical Status: In Progress Type: Bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@swashata