test: fix and add tests for babel-loader cache

Update snapshots for new options added to babel-loader. Also add test case for specificity. See #472
swashata · Apr 28, 2019 · b39950c · b39950c
1 parent e87abd6
commit b39950c
Show file tree

Hide file tree

Showing 2 changed files with 18 additions and 5 deletions.
diff --git a/packages/scripts/__tests__/config/WebpackConfigHelper.spec.ts b/packages/scripts/__tests__/config/WebpackConfigHelper.spec.ts
@@ -168,7 +168,7 @@ describe('CreateWebPackConfig', () => {
 	// getModule()
 	describe('getModule', () => {
 		describe('babel-loader for typescript and javascript', () => {
-			test('has babel-loader', () => {
+			test('has babel-loader with caching', () => {
 				const cwc = new WebpackConfigHelper(
 					projectConfig.files[0],
 					getConfigFromProjectAndServer(projectConfig, serverConfig),
@@ -182,6 +182,11 @@ describe('CreateWebPackConfig', () => {
 					jsTsRules.forEach(rule => {
 						if (rule && rule.use) {
 							expect(rule.use[0].loader).toBe('babel-loader');
+							expect(rule.use[0].options).toMatchObject({
+								cacheDirectory: true,
+								cacheCompression: !true,
+								compact: !true,
+							});
 						} else {
 							throw new Error('JavaScript rule is undefined');
 						}
@@ -233,7 +238,7 @@ describe('CreateWebPackConfig', () => {
 				}
 			});
 
-			test('does not set babel-loader option for js and ts files if useBabelConfig is true', () => {
+			test('does not set babel-loader options except cache for js and ts files if useBabelConfig is true', () => {
 				const cwc = new WebpackConfigHelper(
 					projectConfig.files[0],
 					{
@@ -252,9 +257,11 @@ describe('CreateWebPackConfig', () => {
 					expect(jsTsRules).toHaveLength(2);
 					jsTsRules.forEach(rule => {
 						if (rule && rule.use && rule.use[0].options) {
-							expect(JSON.stringify(rule.use[0].options)).toBe(
-								JSON.stringify({})
-							);
+							expect(rule.use[0].options).toEqual({
+								cacheDirectory: true,
+								cacheCompression: !true,
+								compact: !true,
+							});
 						} else {
 							throw new Error('JavaScript rule is undefined');
 						}

diff --git a/packages/scripts/__tests__/config/__snapshots__/WebpackConfigHelper.spec.ts.snap b/packages/scripts/__tests__/config/__snapshots__/WebpackConfigHelper.spec.ts.snap
@@ -39,6 +39,9 @@ Object {
           "loader": "babel-loader",
           "options": Object {
             "babelrc": false,
+            "cacheCompression": false,
+            "cacheDirectory": true,
+            "compact": false,
             "configFile": false,
             "presets": Array [
               Array [
@@ -67,6 +70,9 @@ Object {
           "loader": "babel-loader",
           "options": Object {
             "babelrc": false,
+            "cacheCompression": false,
+            "cacheDirectory": true,
+            "compact": false,
             "configFile": false,
             "presets": Array [
               Array [