Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tweak Python versions in CI #90

Merged
merged 4 commits into from
Jul 5, 2024
Merged

Tweak Python versions in CI #90

merged 4 commits into from
Jul 5, 2024

Conversation

bfontaine
Copy link
Collaborator

@bfontaine bfontaine commented Jun 24, 2024

This should fix the build for #89.

@bfontaine
Copy link
Collaborator Author

bfontaine commented Jun 24, 2024

This seems to be stuck: it’s waiting for the build on 2.7, but I removed it so it will never run.

Edit: I opened this discussion about the issue.

Copy link
Owner

@swaroopch swaroopch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

Do we need to remove this line

'Programming Language :: Python :: 2',
?

@bfontaine
Copy link
Collaborator Author

I was thinking that we could keep the Python 2.7 support as a "best effort": remove it from the CI but keep the code for it, at least for now.

@swaroopch
Copy link
Owner

I was thinking that we could keep the Python 2.7 support as a "best effort": remove it from the CI but keep the code for it, at least for now.

I'm ok with that 👍🏽

@bfontaine
Copy link
Collaborator Author

@swaroopch I think this is stuck; the only way I see to fix this is to temporarily unprotect master, merge the PR, then protect it again.

@swaroopch swaroopch merged commit 11f0843 into master Jul 5, 2024
7 checks passed
@swaroopch swaroopch deleted the ci-python-ver branch July 5, 2024 00:54
@swaroopch
Copy link
Owner

Force merged, let me know if that helps.

@bfontaine
Copy link
Collaborator Author

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants