Update GameIDs Pattern Documentation #437
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@TylerChasse - Will get this look at this weekend. |
|
@TylerChasse - I was reviewing this, and when I looked at the pattern I thought, that's not a regular expression pattern. I then went and look at all the other documentation and saw that same. Clearly, we need a major update in the future to fix all of that. A better name would have been "example", and then have an actual regex pattern. Here, the pattern So, there is no need in this PR to rewrite all documentation. 😀 Accepted. Thanks!!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated documentation in cumestatsplayer.md and parameters.md to make the formatting of GameIDs more clear.
Resolves #309