update ScoreBoard game_date property name to score_board_date #422
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
minor PR but it looks like there's a mismatch in the documented property name for the game in
ScoreBoard(), and the implementation. The docs say.game_datebut it's implemented as.score_board_date. Alternatively, I can instead change what's in https://github.com/swar/nba_api/blob/5853b5469c436d9489ef355235209daa3a300bba/src/nba_api/live/nba/endpoints/scoreboard.py to switch fromscoreboard_game_datetogame_databut I figured this change to the docs would be less risky.