Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/fix headers #126

Closed
wants to merge 2 commits into from
Closed

Fix/fix headers #126

wants to merge 2 commits into from

Conversation

danchyy
Copy link

@danchyy danchyy commented Jan 23, 2020

Pull request which is handling issues #124 and #125 regarding headers and time outed connections.

Also included the fix which adds Carmelo Anthony as an active player which is mentioned in issue #105 .

@danchyy danchyy mentioned this pull request Jan 23, 2020
@swar
Copy link
Owner

swar commented Jan 24, 2020

@danchyy

I want to give you credit for the headers fix, but I need you to separate this with the Carmelo commit you created. There is a tool to generate the static player file and I want to avoid commits in that file that appear to have done manual edits.

@danchyy
Copy link
Author

danchyy commented Jan 24, 2020

No problem, do you want me to update PR, or will you do the changes now during the weekend? I am already doing to workaround which you said in the issue, so it's the same for me.

@swar
Copy link
Owner

swar commented Jan 24, 2020

@danchyy

Feel free to update the PR or create a new one with just the headers. I am going to update them when I make the update regardless so your call!

@gimann421
Copy link

Noob here, is it fixed? When it is done do I need to pip uninstall and pip install again?

@swar swar closed this Jan 27, 2020
@swar
Copy link
Owner

swar commented Jan 27, 2020

@gimann421 will be up shortly. You can follow those steps and it will update on your end.

@danchyy danchyy deleted the fix/fix-headers branch January 27, 2020 08:17
@danchyy
Copy link
Author

danchyy commented Jan 27, 2020

Thanks for adding it man, I was traveling during weekend so didn't really find time to clean up PR, great job :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants