Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[draft] Real galaxy images through paltas' GalaxyCatalog #7

Merged
merged 19 commits into from
Mar 13, 2023

Conversation

JelleAalbers
Copy link
Collaborator

This

  • Changes the models in the lensing config to be instances, not classes. Since all the existing models have only staticmethods, this does not change any behavior.
  • Adds a new source model, PaltasGalaxyCatalog, which can wrap a paltas catalog that can produce real galaxies. Paltas is not added as a dependency, although you won't be able to use PaltasGalaxyCatalog without it.
  • Adds a temporary notebook draw_real_galaxy_image.ipynb to show how it works.

Still missing:

  • Unit tests
  • K-corrections
  • Parameters for specifying the absolute or apparent magnitude (currently there is just the amp parameter)

Unfortunately PaltasGalaxyCatalog requires the cosmology parameters with lookup tables on initialization. Since we don't want to initialize those in the config file (as they have an RNG), intializing the class is currently a kludge, as you can see in the notebook.

JelleAalbers and others added 19 commits March 6, 2023 13:11
…rty of all lens and source models. It not gets used in the input_pipeline script and should allow us to specify physical parameters in the configs for our models and have the input pipeline deal with transforming those arguments to angular values
… more work to be integrated into input pipeline
Update real_galaxies to main.
… information into cosmology_params. Saving as a property of the class or as a global variable leads to massive memory consumption.
@swagnercarena swagnercarena merged commit c08e737 into main Mar 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants