-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[draft] Real galaxy images through paltas' GalaxyCatalog #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…it to make review easier.
…rty of all lens and source models. It not gets used in the input_pipeline script and should allow us to specify physical parameters in the configs for our models and have the input pipeline deal with transforming those arguments to angular values
… more work to be integrated into input pipeline
…o do a little more testing
Update real_galaxies to main.
… information into cosmology_params. Saving as a property of the class or as a global variable leads to massive memory consumption.
swagnercarena
approved these changes
Mar 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This
PaltasGalaxyCatalog
, which can wrap a paltas catalog that can produce real galaxies. Paltas is not added as a dependency, although you won't be able to usePaltasGalaxyCatalog
without it.draw_real_galaxy_image.ipynb
to show how it works.Still missing:
amp
parameter)Unfortunately
PaltasGalaxyCatalog
requires the cosmology parameters with lookup tables on initialization. Since we don't want to initialize those in the config file (as they have an RNG), intializing the class is currently a kludge, as you can see in the notebook.