fleshed out the comparison notebook and caught a few bugs #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
March 3, 2023 01:21
…ere 1) input_config had too small a sampling value for position of the subhalos, so most subhalos being sampled were far outside the Einstein radius and 2) Dex scatter was set to 0.0, but a non-zero dex scatter occasionally produces higher concentration halos which increase signal. No meaningful bugs in the actual jaxstronomy code, but I did change the way brightness normalization is done (now the images coming out of image_simulation are normalzied to the supersampling resolution pixel_scale and the downsampling code sums instead of doing a mean.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ere 1) input_config had too small a sampling value for position of the subhalos, so most subhalos being sampled were far outside the Einstein radius and 2) Dex scatter was set to 0.0, but a non-zero dex scatter occasionally produces higher concentration halos which increase signal. No meaningful bugs in the actual jaxstronomy code, but I did change the way brightness normalization is done (now the images coming out of image_simulation are normalzied to the supersampling resolution pixel_scale and the downsampling code sums instead of doing a mean.