Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added a WeightedCatalog class with corresponding test functions #25

Merged
merged 9 commits into from
May 29, 2024

Conversation

ahuang314
Copy link
Contributor

Added a WeightedCatalog class with corresponding test functions

Copy link
Owner

@swagnercarena swagnercarena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Made two small comments to change.

paltax/source_models.py Show resolved Hide resolved
Arguments with any physical units parameters converted to angular
units.
"""
# Select the galaxy incdex from the uniform distribution.
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo

@coveralls
Copy link

Pull Request Test Coverage Report for Build 9276561387

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+1.6%) to 98.664%

Totals Coverage Status
Change from base Build 8809543932: 1.6%
Covered Lines: 1698
Relevant Lines: 1721

💛 - Coveralls

@swagnercarena swagnercarena merged commit 7996c83 into swagnercarena:main May 29, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants