Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Config mods #15

Merged
merged 13 commits into from
Mar 28, 2024
Merged

Config mods #15

merged 13 commits into from
Mar 28, 2024

Conversation

swagnercarena
Copy link
Owner

A few major changes:

  • Broke out job of running training script into main.py
  • Put more of the inputs to the training script into the configuration file and started using FieldReferences in the configuration file to make updating parameters easy.
  • Added new tests for train.py and train_snpe.py to improve coverage.
  • Simplified config files by using base config files. Will make it easier to propagate changes moving forward.

@swagnercarena
broke training into main script and train script. Configs still need …
720e85a 
…updates to match new choice.
@swagnercarena
remove coveralls for now because of private repo
f6ad664
@swagnercarena
polished train.py and train_snpe.py and moved running training to new…
5a6f086 
… main.py file. Still need to modify configs to agree with new main.py requirements and test train.py and train_snpe.py changes.
@swagnercarena
modified configs to have required parameters and cleaned up config se…
5924933 
…lection.
@swagnercarena
add back run_hierarchical for now.
76b0715
@swagnercarena
using FieldReference in config and more tests for train script.
c4099ae
@swagnercarena
train.py now fully tested
f8bdfdd
@swagnercarena
finished testing train_snpe.py and modifying config files. Need to ru…
effd207 
…n one more set of tests on a gpu cluster to make sure it hasn't altered model behavior.
@swagnercarena
small reformat of config file for style.
176363f
@swagnercarena
Merge branch 'main' into config_mods
18937c8
@swagnercarena
fix to main.py
2fcb2ba
@swagnercarena
using config flags for main instead
e75874a
@swagnercarena
add test for _get_refinement_step_list
fd0ca4a
@swagnercarena swagnercarena merged commit 106ffbc into main Mar 28, 2024
1 check passed
@swagnercarena swagnercarena deleted the config_mods branch March 28, 2024 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@swagnercarena