-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: multi-arch docker image #1756
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 But I would incorporate some further improvements tnaroska#1
With that you can also test in your fork if you create a tag in the form of v*
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1756 +/- ##
=======================================
Coverage 83.40% 83.40%
=======================================
Files 16 16
Lines 3881 3881
=======================================
Hits 3237 3237
Misses 545 545
Partials 99 99 ☔ View full report in Codecov by Sentry. |
Update and resolve the conflicts, please. |
- adapt Dockerfile to support cross-compilation depending on TARGETARCH and TARGETOS variables see https://www.docker.com/blog/faster-multi-platform-builds-dockerfile-cross-compilation-guide/ - set target platforms for docker/build-push-action
@sdghchj done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@tnaroska Thanks for your contribution. |
Describe the PR
Fix #1755 by enabling go cross-compilation in Dockerfile and setting multiple target architectures in docker/build-push-action.
Relation issue
#1755 - Create multi-arch docker image for amd64/arm64
Additional context
Validated the Dockerfile change by building a multi-arch image locally.
I have no way to test the change in github worklfow though.Thanks to @ngehrsitz, changes to github workflow could be validated on this fork repo, too.