Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: SchemaExample: allow \r \n \t #1156

Merged
merged 1 commit into from
Mar 15, 2022
Merged

feat: SchemaExample: allow \r \n \t #1156

merged 1 commit into from
Mar 15, 2022

Conversation

mschneider82
Copy link
Contributor

@codecov
Copy link

codecov bot commented Mar 8, 2022 •
edited
Loading

Codecov Report

Merging #1156 (2854f34) into master (334111b) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head 2854f34 differs from pull request most recent head 62d66dc. Consider uploading reports for the commit 62d66dc to get more accurate results

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1156   +/-   ##
=======================================
  Coverage   94.76%   94.76%           
=======================================
  Files          10       10           
  Lines        2443     2447    +4     
=======================================
+ Hits         2315     2319    +4     
  Misses         67       67           
  Partials       61       61
Impacted Files Coverage Δ
operation.go 96.00% <100.00%> (+0.02%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 334111b...62d66dc. Read the comment docs.

ubogdan
ubogdan requested changes Mar 8, 2022
View reviewed changes
Copy link
Contributor

@ubogdan ubogdan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comments...

@mschneider82 mschneider82 requested a review from ubogdan March 10, 2022 10:56
@mschneider82 mschneider82 changed the title feat: Example/SchemaExample: allow \r \n \t feat: SchemaExample: allow \r \n \t Mar 10, 2022
ubogdan
ubogdan previously approved these changes Mar 10, 2022
View reviewed changes
Copy link
Contributor

@ubogdan ubogdan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ubogdan
Copy link
Contributor

ubogdan commented Mar 10, 2022

Can you please update the README.md accordingly?

ubogdan
ubogdan approved these changes Mar 15, 2022
View reviewed changes
Copy link
Contributor

@ubogdan ubogdan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ubogdan ubogdan merged commit 32b2467 into swaggo:master Mar 15, 2022
@ubogdan
Copy link
Contributor

ubogdan commented Mar 15, 2022

@mschneider82 Thanks for your contribution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ubogdan ubogdan ubogdan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mschneider82 @ubogdan