Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@swagger-api/apidom-ls #8

Closed

Conversation

krivaa-attensi
Copy link

Hi, we've had failures from this Github action
swagger-api/apidom#4539

This forked version is succeeding, but of course not a sustainable pinning to an alpha version, but though it was better to open a PR than an issue. Thanks for creating the Github action!

It's currently failing with:

/workspace/node_modules/tree-sitter/index.js:361
    ? parse.call(
            ^
Error: Invalid argument
    at Parser.parse (/workspace/node_modules/tree-sitter/index.js:361:13)
    at analyze (/workspace/node_modules/@swagger-api/apidom-parser-adapter-yaml-1-2/src/lexical-analysis/node.cjs:19:17)
    at Object.parse (/workspace/node_modules/@swagger-api/apidom-parser-adapter-yaml-1-2/src/adapter-node.cjs:39:39)
    at parse (/workspace/node_modules/@swagger-api/apidom-ls/src/parser-factory.cjs:98:32)
    at process.processTicksAndRejections (node:internal/process/task_queues:95:5)
    at async Object.get (/workspace/node_modules/@swagger-api/apidom-ls/src/document-cache.cjs:54:30)
    at async DefaultValidationService.doValidation (/workspace/node_modules/@swagger-api/apidom-ls/src/services/validation/validation-service.cjs:323:18)
    at async /workspace/validate.cjs:53:28
Node.js v20.10.0

@char0n
Copy link
Member

char0n commented Dec 29, 2024

Is this still an issue?

@bxsx
Copy link

bxsx commented Dec 29, 2024

@char0n I believe it is still the issue, yes

char0n added a commit that referenced this pull request Dec 30, 2024
@char0n
Copy link
Member

char0n commented Dec 30, 2024

I've addressed this in 0d9dea2 and 782e6a5 which now makes sure ApiDOM is installed from latest tag and above the corrupted beta1 and beta2 releases.

This upstream ApiDOM issue was resolved in https://github.com/swagger-api/apidom/releases/tag/v1.0.0-beta.1 and https://github.com/swagger-api/apidom/releases/tag/v1.0.0-beta.2 respectively. So if latest version of ApiDOM is used, the issue no longer manifests.

@char0n
Copy link
Member

char0n commented Dec 30, 2024

@krivaa-attensi thanks for this workaround - there was a new 1.3.0 release, which addresses this issue. You shoudn't see it any more.

Can you please confirm? Thanks

@char0n char0n closed this Dec 30, 2024
@krivaa-attensi krivaa-attensi deleted the pin-apidom-ls branch January 6, 2025 09:27
@krivaa-attensi
Copy link
Author

@krivaa-attensi thanks for this workaround - there was a new 1.3.0 release, which addresses this issue. You shoudn't see it any more.

Can you please confirm? Thanks

Yeah, the new version with the new org name looks to work well now, thanks a lot 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants