Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

revert(patch-package): temporarily remove postinstall hook #8287

Merged
merged 1 commit into from
Nov 9, 2022

Conversation

tim-lai
Copy link
Contributor

@tim-lai tim-lai commented Nov 9, 2022

Description

Temporarily remove the postinstall hook for patch-package so that downstream projects can still build with SwaggerUI.

Motivation and Context

There is a deployment regression introduced in PR #8266. Probably need to copy over patched files as part of webpack build workflow, or possibly moving patch-package to a production dependency. Further investigation required.

How Has This Been Tested?

Visible in downstream SwaggerEditor failed release, logs here

Screenshots (if appropriate):

Checklist

My PR contains...

  • No code changes (src/ is unmodified: changes to documentation, CI, metadata, etc.)
  • Dependency changes (any modification to dependencies in package.json)
  • Bug fixes (non-breaking change which fixes an issue)
  • Improvements (misc. changes to existing features)
  • Features (non-breaking change which adds functionality)

My changes...

  • are breaking changes to a public API (config options, System API, major UI change, etc).
  • are breaking changes to a private API (Redux, component props, utility functions, etc.).
  • are breaking changes to a developer API (npm script behavior changes, new dev system dependencies, etc).
  • are not breaking changes.

Documentation

  • My changes do not require a change to the project documentation.
  • My changes require a change to the project documentation.
  • If yes to above: I have updated the documentation accordingly.

Automated tests

  • My changes can not or do not need to be tested.
  • My changes can and should be tested by unit and/or integration tests.
  • If yes to above: I have added tests to cover my changes.
  • If yes to above: I have taken care to cover edge cases in my tests.
  • All new and existing tests passed.

@tim-lai tim-lai added the dependencies Pull requests that update a dependency file label Nov 9, 2022
@tim-lai
Copy link
Contributor Author

tim-lai commented Nov 9, 2022

fyi @DreierF

@tim-lai tim-lai merged commit 6cbee7e into swagger-api:master Nov 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant