fix(sample-gen): additionalProps generation for minProperties=1 #7431
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes an issue where an empty example was generated for an object with
additionalProperties
andminProperties: 1
. And in general, examples forminProperties: N
+additionalProperties
were generated with N-1 properties.The issue occurred because the loop that added additionalProps used
<
instead of<=
to check the exit condition, and so it never executed whentoGenerateCount
was 1.swagger-ui/src/core/plugins/samples/fn.js
Line 484 in de3d063
Motivation and Context
Fix/improve example generation.
How Has This Been Tested?
Tested manually + added tests.
Example 1
Sample schema:
Result before the fix:
After the fix:
Example 2
Sample schema:
Result before the fix:
After the fix:
Screenshots (if appropriate):
n/a
Checklist
My PR contains...
src/
is unmodified: changes to documentation, CI, metadata, etc.)package.json
)My changes...
Documentation
Automated tests