Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: style of the "nullable" attribute in object schemas #6265

Merged
merged 2 commits into from
Jul 28, 2020

Conversation

hkosova
Copy link
Contributor

@hkosova hkosova commented Jul 24, 2020

Description

This PR fixes the styling of the nullable: true attribute in object schemas. It replaces the inline style with propClass similar to what was done in PR #5578.

Motivation and Context

Style fix.

How Has This Been Tested?

Manually.

Screenshots (if appropriate):

image

Checklist

My PR contains...

  • No code changes (src/ is unmodified: changes to documentation, CI, metadata, etc.)
  • Dependency changes (any modification to dependencies in package.json)
  • Bug fixes (non-breaking change which fixes an issue)
  • Improvements (misc. changes to existing features)
  • Features (non-breaking change which adds functionality)

My changes...

  • are breaking changes to a public API (config options, System API, major UI change, etc).
  • are breaking changes to a private API (Redux, component props, utility functions, etc.).
  • are breaking changes to a developer API (npm script behavior changes, new dev system dependencies, etc).
  • are not breaking changes.

Documentation

  • My changes do not require a change to the project documentation.
  • My changes require a change to the project documentation.
  • If yes to above: I have updated the documentation accordingly.

Automated tests

  • My changes can not or do not need to be tested.
  • My changes can and should be tested by unit and/or integration tests.
  • If yes to above: I have added tests to cover my changes.
  • If yes to above: I have taken care to cover edge cases in my tests.
  • All new and existing tests passed.

@hkosova hkosova changed the title Fix the style of the "nullable" attribute in object schemas fix: style of the "nullable" attribute in object schemas Jul 24, 2020
@tim-lai tim-lai self-assigned this Jul 28, 2020
@tim-lai tim-lai merged commit bd9117d into swagger-api:master Jul 28, 2020
@hkosova hkosova deleted the bug/inline-styles branch July 29, 2020 07:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants