Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added fix for issue 959 #960

Merged
merged 3 commits into from
Mar 18, 2019
Merged

added fix for issue 959 #960

merged 3 commits into from
Mar 18, 2019

Conversation

r-sreesaran
Copy link
Contributor

@r-sreesaran r-sreesaran commented Dec 1, 2018

fix for issue #959

Copy link
Contributor

@ymohdriz ymohdriz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @r-sreesaran,

Please find below my suggestions.

  1. It's always better to assert the exact message instead of messages size.
  2. Add a test case that no warning should throw when parameter with same name and location in both the operation and path level.
  3. Add a test case that duplicate parameter should check in operation level or path level.
  4. We have to handle the reference parameter (both internal and external). Please add a TC to cover this scenario.
  5. Warning added in getParameters() is not required. Warning added in getParametersList() is enough.

Thanks,
Mohammed Rizwan

@gracekarina
Copy link
Contributor

Hi, thanks for this PR. I suggest to divide the test in two, instead of evaluating two different specs in one test. @r-sreesaran

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants