-
Notifications
You must be signed in to change notification settings - Fork 531
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Composite types] When allOf contains only one type don't generate union classes #2054
base: master
Are you sure you want to change the base?
Conversation
Hi @SergioArrighi, this change breaks many tests, this could be added as an option if you follow the logic of the resolveCombinators option. thanks Failures: |
if (n.isObject()) { | ||
schema = getSchema((ObjectNode) n, location, result); | ||
composedSchema.addAllOfItem(schema); | ||
if (allOfArray.size() > 1) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if this is going to be a new behavior, you could add it as an option, as the option resolveCombinators
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if this is going to be a new behavior, you could add it as an option, as the option resolveCombinators
Hello @gracekarina , |
Hello all,
I don't know if this may be of interest, but I think I saw some issues logged here and there of people asking for this kind of behaviour.
I originally wanted to make it optional, but I did't find any way to have some kind of configuration.
Thanks for the awesome work everybody and best regards.