We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SwaggerSpecConverter.prototype.convert() is not taking into account the basePath for a resourceListing.
SwaggerSpecConverter.prototype.convert()
in /lib/client.js (https://github.com/swagger-api/swagger-js/blob/master/lib/client.js#L182-L183) you are passing in self.url which I'm sure is fine for almost everyone but not for hapi-swagger's output.
/lib/client.js
I did a simple test of setting the docLocation by adding the following AFTER line 34: https://github.com/swagger-api/swagger-js/blob/master/lib/spec-converter.js#L34
// basePath if (obj.basePath) { this.setDocumentationLocation(obj.basePath); }
Once this was added, everything worked like a charm.
The text was updated successfully, but these errors were encountered:
hmm could you send a PR and we can test?
Sorry, something went wrong.
done
fix for #346
c02cffc
No branches or pull requests
SwaggerSpecConverter.prototype.convert()
is not taking into account the basePath for a resourceListing.in
/lib/client.js
(https://github.com/swagger-api/swagger-js/blob/master/lib/client.js#L182-L183) you are passing in self.url which I'm sure is fine for almost everyone but not for hapi-swagger's output.I did a simple test of setting the docLocation by adding the following AFTER line 34:
https://github.com/swagger-api/swagger-js/blob/master/lib/spec-converter.js#L34
Once this was added, everything worked like a charm.
The text was updated successfully, but these errors were encountered: