Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce backward compatible URI Reference resolution #3147

Closed
char0n opened this issue Sep 18, 2023 · 3 comments
Closed

Introduce backward compatible URI Reference resolution #3147

char0n opened this issue Sep 18, 2023 · 3 comments
Assignees
@char0n
Labels
type: regression version: 3.x

Comments

@char0n
Copy link
Member

char0n commented Sep 18, 2023

In https://github.com/swagger-api/swagger-js/releases/tag/v3.21.0 we've drop legacy url depedency and replaced it with new URL API. New URL API is not capable of resolving Relative URI References against Relative URI Reference. We've made sure that latest SwaggerUI version always sends absolute baseURL, but earlier EOL versions of SwaggerUI (v3 and v4) and legacy SwaggerEditor@4 are affected by this change.

The goal of this issue is to provide backward compatible behavior while resolving Relative URI References.

Refs swagger-api/swagger-ui#9215
@char0n char0n self-assigned this Sep 18, 2023
char0n added a commit that referenced this issue Sep 18, 2023
@char0n
fix(specmap): add backward compat relative URL Reference resolution
54d9f83 
Refs #3147
@char0n char0n mentioned this issue Sep 18, 2023
Merged
char0n added a commit that referenced this issue Sep 18, 2023
@char0n
fix(specmap): add backward compatible relative URI Reference resoluti…
1b17ba1 
…on (#3148)

Refs #3147
swagger-bot pushed a commit that referenced this issue Sep 18, 2023
@semantic-release-bot
chore(release): cut the 3.22.2 release [skip ci]
cd84a30 
## [3.22.2](v3.22.1...v3.22.2) (2023-09-18)

### Bug Fixes

* **specmap:** add backward compatible relative URI Reference resolution ([#3148](#3148)) ([1b17ba1](1b17ba1)), closes [#3147](#3147)
@char0n
Copy link
Member Author

char0n commented Sep 18, 2023

Addressed in #3148 and released in v3.22.2

@char0n char0n closed this as completed Sep 18, 2023
@AlvaroRausell
Copy link

Hi @char0n, this PR has broken our repos on Windows, as the cwd value has backslashes and line 82 fails with [ERR_INVALID_URL]: Invalid URL.
Could you please correct this behaviour by normalising the paths before resolving?

@AlvaroRausell
Copy link

Opened #3149

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@char0n char0n

Labels
type: regression version: 3.x
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@char0n @AlvaroRausell