Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add gzip compression in nginx configuration to reduce file size #1953

Merged
merged 1 commit into from
Feb 26, 2019
Merged

Add gzip compression in nginx configuration to reduce file size #1953

merged 1 commit into from
Feb 26, 2019

Conversation

yodeyer
Copy link
Contributor

@yodeyer yodeyer commented Feb 24, 2019

Description

The purpose is to reduce the loading time by reducing the amount of data transferred.

With a simulated 100 mbps internet connection :

  • before :
    image
  • after :
    image

gzip_static reduces the CPU used by nginx, by avoiding to gzip files for each request.

Motivation and Context

It reduces loading time by more than 1.5 second (and even more on a slow internet connection).

How Has This Been Tested?

I compared network tab in Chrome Developer Tools with and without gzip.

Checklist

My PR contains...

  • No code changes (src/ is unmodified: changes to documentation, CI, metadata, etc.)
  • Dependency changes (any modification to dependencies in package.json)
  • Bug fixes (non-breaking change which fixes an issue)
  • Improvements (misc. changes to existing features)
  • Features (non-breaking change which adds functionality)

My changes...

  • are breaking changes to a public API (config options, System API, major UI change, etc).
  • are breaking changes to a private API (Redux, component props, utility functions, etc.).
  • are breaking changes to a developer API (npm script behavior changes, new dev system dependencies, etc).
  • are not breaking changes.

Documentation

  • My changes do not require a change to the project documentation.
  • My changes require a change to the project documentation.
  • If yes to above: I have updated the documentation accordingly.

Automated tests

  • My changes can not or do not need to be tested.
  • My changes can and should be tested by unit and/or integration tests.
  • If yes to above: I have added tests to cover my changes.
  • If yes to above: I have taken care to cover edge cases in my tests.
  • All new and existing tests passed.

@shockey
Copy link
Contributor

shockey commented Feb 26, 2019

please build

@shockey shockey merged commit 731df8e into swagger-api:master Feb 26, 2019
@shockey
Copy link
Contributor

shockey commented Feb 26, 2019

thanks @yodeyer!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants