Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feedback why 'Import'-button is not pressable wanted #638

Closed
dothebart opened this issue Sep 10, 2015 · 4 comments
Closed

feedback why 'Import'-button is not pressable wanted #638

dothebart opened this issue Sep 10, 2015 · 4 comments
Labels
type: bug
Milestone
2.9.8

Comments

@dothebart
Copy link

I tried to use 'import from url' to import the swagger json from... https://raw.githubusercontent.com/arangodb/arangodb/devel/js/apps/system/_admin/aardvark/APP/api-docs.json
The mouse over on the button shows a 'parking forbidden' icon, but no reason why.
It seems it can either be that its still processing everything (in that case a progress would be nice) or the format of the file is invalid.
@dothebart
Copy link
Author

https://gist.github.com/5600eec47e9883527e87 has "required": [], in line 48 which is wrong. Loading the File via json will also do nothing, only pasting it into the 'Paste JSON' window gave me tracks to the error.

@mohsen1
Copy link
Contributor

mohsen1 commented Sep 10, 2015

I believe editor goes to an infinite loop with your spec (the one you posted on original issue). I'm looking into it.

@dothebart
Copy link
Author

maybe showing a throbber while its loading is a good thing to have?
Since all the parsing can take a while... Even if there is no infinite loop ;-)

@mohsen1
Copy link
Contributor

mohsen1 commented Sep 11, 2015

I've closed this bug which was related to the import dialog. the swagger you have in that URL still crashes the editor but I'll open a separate issue if I can confirm what exactly is going on

@mohsen1 mohsen1 added this to the 2.9.8 milestone Sep 11, 2015
@mohsen1 mohsen1 mentioned this issue Sep 11, 2015
Closed
tim-lai pushed a commit that referenced this issue Jun 9, 2022
@char0n
feat(editor): expose editor instance on global object (#646)
2b54bc4 
Refs #638
tim-lai pushed a commit that referenced this issue Jun 9, 2022
@semantic-release-bot
chore(release): cut the 0.12.0 release [skip ci]
bf081b0 
# [0.12.0](https://github.com/swagger-api/swagger-ide/compare/v0.11.0...v0.12.0) (2022-04-14)

### Features

* **editor:** expose editor instance on global object ([#646](https://github.com/swagger-api/swagger-ide/issues/646)) ([2b54bc4](https://github.com/swagger-api/swagger-ide/commit/2b54bc4635c8f15f51ee61bc70b1c56c91c2afdb)), closes [#638](https://github.com/swagger-api/swagger-ide/issues/638)
* EditorLocalStoragePlugin ([#640](https://github.com/swagger-api/swagger-ide/issues/640)) ([8ec4a7c](https://github.com/swagger-api/swagger-ide/commit/8ec4a7cc93bdcd7f27b3392e1a4c98691f8081a9))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type: bug
Projects
None yet
Milestone
2.9.8
Development

No branches or pull requests
2 participants
@mohsen1 @dothebart