Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

useBackendForStorage not issuing PUTs #598

Closed
jadbox opened this issue Aug 24, 2015 · 5 comments
Closed

useBackendForStorage not issuing PUTs #598

jadbox opened this issue Aug 24, 2015 · 5 comments

Comments

@jadbox
Copy link

jadbox commented Aug 24, 2015

When I useBackendForStorage to true with swagger-editor 2.9.6, I see that a GET request is made from editor/spec but never a PUT/POST to save changes. I've even looked at my browser network logs and found that the editor is never attempting to save... even though I get the successful validation notification popup (in the top corner) when changes are made.

@jadbox
Copy link
Author

jadbox commented Aug 24, 2015

I also tried adding/removing the following config options: "enableBackendHealthCheck", "backendHealthCheckTimeout" too.

Current config:

{
  "codegen": {
    "clients": "http://generator.swagger.io/api/gen/clients",
    "client": "http://generator.swagger.io/api/gen/clients/{language}"
  },
  "analytics": {
    "google": {
        "id": -1
      }
    },
  "disableCodeGen": false,
  "examplesFolder": "/",
  "editorOptions": {
    "theme": "ace/theme/atom_dark"
  },
  "exampleFiles": [],
  "autocompleteExtension": {},
  "useBackendForStorage": true,
  "backendThrottle": 200,
  "backendEndpoint": "/editor/spec",
  "backendHealthCheckTimeout": 5000,
  "useYamlBackend": false,
  "disableFileMenu": false,
  "headerBranding": false,
  "enableTryIt": true,
  "brandingCssClass": "",
  "enableBackendHealthCheck": false,
  "backendHealthCheckTimeout": -1
}

@mohsen1
Copy link
Contributor

mohsen1 commented Aug 24, 2015

Duplicate of #592

@mohsen1 mohsen1 closed this as completed Aug 24, 2015
@jadbox
Copy link
Author

jadbox commented Aug 24, 2015

@mohsen1 I don't think this is a duplicate because the middleware doesn't error and I don't even see from the browser's perspective ANY call to PUT data for /editor/spec.

@gietl
Copy link

gietl commented Aug 27, 2015

@jadbox I am seeing the same thing when having useYamlBackend set to false. If it's set to true, it will successfully send a PUT, but then the data is in yaml format and not json.

@mohsen1 mohsen1 reopened this Aug 27, 2015
@mohsen1 mohsen1 added this to the 2.9.8 milestone Sep 9, 2015
@jadbox
Copy link
Author

jadbox commented Sep 16, 2015

@gietl Confirmed... setting useYamlBackend to True allows backend saving.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants