Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SwaggerEditor@next: avoid creating two monaco editor instances #4970

Closed
char0n opened this issue Apr 24, 2024 · 1 comment
Closed

SwaggerEditor@next: avoid creating two monaco editor instances #4970

char0n opened this issue Apr 24, 2024 · 1 comment
Assignees
@char0n
Labels
swagger-editor@next type: bug

Comments

@char0n
Copy link
Member

char0n commented Apr 24, 2024

We don't have explicit prevention mechanism to avoid creating two monaco editor instances. The goal of this issue is to create one and prevent rendering multiple monaco editors in single DOM container.
@char0n char0n self-assigned this Apr 24, 2024
char0n added a commit that referenced this issue Apr 24, 2024
@char0n
fix(monaco-editor): avoid rendering Monaco Editor multiple times
45a6ae8 
Refs #4970
@char0n char0n mentioned this issue Apr 24, 2024
Merged
@char0n
Copy link
Member Author

char0n commented Apr 24, 2024

Addressed in #4971

@char0n char0n closed this as completed Apr 24, 2024
char0n added a commit that referenced this issue Apr 24, 2024
@char0n
fix(monaco-editor): avoid rendering Monaco Editor multiple times (#4971)
47f9798 
Refs #4970
swagger-bot pushed a commit that referenced this issue Apr 24, 2024
@semantic-release-bot
chore(release): cut the 5.0.0-alpha.93 release
a37ce80 
# [5.0.0-alpha.93](v5.0.0-alpha.92...v5.0.0-alpha.93) (2024-04-24)

### Bug Fixes

* **monaco-editor:** avoid rendering Monaco Editor multiple times ([#4971](#4971)) ([47f9798](47f9798)), closes [#4970](#4970)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@char0n char0n

Labels
swagger-editor@next type: bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@char0n