Add @BeanParam support for Jersey2. #536
Closed
+121
−87
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Related Issue: #446 Add @BeanParam support. Add unit test for @BeanParam support. Fix PathParamTargetTest. The list detailsOps has two items, POST and GET. The order is not guaranteed. Add filter to make sure POST is used for the unit test.
|
The error is: org.scalatest.exceptions.TestFailedException: "...ties":{"theCount":{"[$ref":"Int]"}}}]" was not equal to "...ties":{"theCount":{"[type":"integer","format":"int32]"}}}]" Seems Int is not recognized as a primitive. Tried to run the test case locally and it could pass. |
|
After investigation, the issue is related to a unit test bug. I can reproduce the behavior by adding: To |
|
The build log: https://travis-ci.org/wordnik/swagger-core/builds/23364034 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue: #446
Add
@BeanParamsupport.Add unit test for
@BeanParamsupport.Fix
PathParamTargetTest. The list detailsOps has two items, POST and GET. The order is not guaranteed. Add filter to make sure POST is used for the unit test.