Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reverted JsonUtil.mustache for JavaClientCodegen after PR #726. #739

Merged
merged 1 commit into from
May 12, 2015
Merged

Reverted JsonUtil.mustache for JavaClientCodegen after PR #726. #739

merged 1 commit into from
May 12, 2015

Conversation

tomtit
Copy link
Contributor

@tomtit tomtit commented May 8, 2015

Generated Java sample for the Pet Store is broken after the PR #726:

$ ./bin/java-petstore.sh ; cd samples/client/petstore/java; mvn clean package
...
[INFO] 9 errors 
[INFO] -------------------------------------------------------------
[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 1.936s
[INFO] Finished at: Fri May 08 12:32:56 UTC 2015
[INFO] Final Memory: 13M/303M
[INFO] ------------------------------------------------------------------------
[ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:2.3.2:compile (default-compile) on project swagger-java-client: Compilation failure: Compilation failure:
[ERROR] /home/swagger.io/swagger-codegen/samples/client/petstore/java/src/main/java/io/swagger/client/JsonUtil.java:[3,22] error: package com.google.gson does not exist
[ERROR] /home/swagger.io/swagger-codegen/samples/client/petstore/java/src/main/java/io/swagger/client/JsonUtil.java:[4,22] error: package com.google.gson does not exist
[ERROR] /home/swagger.io/swagger-codegen/samples/client/petstore/java/src/main/java/io/swagger/client/JsonUtil.java:[7,16] error: cannot find symbol
[ERROR] class JsonUtil
[ERROR] /home/swagger.io/swagger-codegen/samples/client/petstore/java/src/main/java/io/swagger/client/JsonUtil.java:[14,16] error: cannot find symbol
[ERROR] class JsonUtil
[ERROR] /home/swagger.io/swagger-codegen/samples/client/petstore/java/src/main/java/io/swagger/client/ApiInvoker.java:[134,36] error: cannot find symbol
[ERROR] class JsonUtil
[ERROR] /home/swagger.io/swagger-codegen/samples/client/petstore/java/src/main/java/io/swagger/client/ApiInvoker.java:[135,42] error: cannot find symbol
[ERROR] class JsonUtil
[ERROR] /home/swagger.io/swagger-codegen/samples/client/petstore/java/src/main/java/io/swagger/client/ApiInvoker.java:[145,23] error: cannot find symbol
[ERROR] class JsonUtil
[ERROR] /home/swagger.io/swagger-codegen/samples/client/petstore/java/src/main/java/io/swagger/client/ApiInvoker.java:[156,23] error: cannot find symbol
[ERROR] class JsonUtil
[ERROR] /home/swagger.io/swagger-codegen/samples/client/petstore/java/src/main/java/io/swagger/client/JsonUtil.java:[10,22] error: cannot find symbol

@who
Copy link
Contributor

who commented May 8, 2015

Oops, sorry about this - In #726 I committed the regular Java jsonutil as well as the android-java jsonutil. This was unintentional, as PR #726 was only meant to change the android-java stack.

+1 to this PR being merged.

@wing328
Copy link
Contributor

wing328 commented May 12, 2015

+1

I was able to repeat the issue with the develop_2.0 branch and this PR resolves the issue.

webron added a commit that referenced this pull request May 12, 2015
Reverted JsonUtil.mustache for JavaClientCodegen after PR #726.
@webron webron merged commit 75ff908 into swagger-api:develop_2.0 May 12, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants