Add option to set request timeout for Javascript request #2287
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@vzeman thanks for the PR. Would you please also update the Javascript petstore samples so that CI can verify the change? Ref: https://github.com/angular/angular.js/blob/master/CONTRIBUTING.md |
|
@wing328 could you please tell me which swagger.json should I use during compiling sample? |
|
If you're on Mac/Linux, just run For windows, please run |
|
@wing328 done, please check if you need anything else from our side. |
|
@vzeman looks good to me. Thanks for your contribution 🍻 |
wing328
added a commit
that referenced
this pull request
Mar 1, 2016
Add option to set request timeout for Javascript request
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.