Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Develop 2.0 - support binary input and output #1065

Closed
wants to merge 1 commit into from

Conversation

boazsapir
Copy link

This is my implementation of Java code generation, including the generic (not language specific) support needed, for binary data in the request body and in the response.
This implementation is based on the agreed spec, as discussed in OAI/OpenAPI-Specification#50 and depends on my pull request to swagger-core which was merged on Aug-6 (swagger-api/swagger-core#1335)

@wing328
Copy link
Contributor

wing328 commented Aug 20, 2015

@boazsapir would you please rebase on the latest develop_2.0 ?

@boazsapir
Copy link
Author

I am currently travelling will do it early next week
On Aug 20, 2015 02:14, "wing328" [email protected] wrote:

@boazsapir https://github.com/boazsapir would you please rebase on the
latest develop_2.0 ?


Reply to this email directly or view it on GitHub
#1065 (comment)
.

…h type "string" and format "binary". Implemented for Java.
@boazsapir
Copy link
Author

@wing328 I have updated this pull request to include only one commit which includes all the changes, rebased (manually) to the latest develop_2.0 code from today

@webron
Copy link
Contributor

webron commented Aug 24, 2015

@boazsapir - I'm afraid that even though you rebased, additional PR merges made it impossible to merge again. I'd have to ask you to rebase again, and resubmit it against the master branch (we moved to it just now).

@boazsapir
Copy link
Author

@webron I created a new PR #1124 for the master branch

@fehguy
Copy link
Contributor

fehguy commented Aug 24, 2015

I've merged #1124. Thanks again!

@fehguy fehguy closed this Aug 24, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants