Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OpenApi 3.1 namespace - support assigning $schema in every Schema Object #362

Closed
char0n opened this issue Apr 14, 2021 · 1 comment · Fixed by #364
Closed

OpenApi 3.1 namespace - support assigning $schema in every Schema Object #362

char0n opened this issue Apr 14, 2021 · 1 comment · Fixed by #364
Assignees
@char0n
Labels
ApiDOM enhancement New feature or request OpenAPI 3.1

Comments

@char0n
Copy link
Member

char0n commented Apr 14, 2021 •
edited
Loading

$schema must be accessible from every Schema Object without traversing it's parents. We'll use meta of Schema Element to store this information there. This needs to be implemented on refractor level and no resolution should be done at this phase.
@char0n char0n added enhancement New feature or request OpenAPI 3.1 ApiDOM labels Apr 14, 2021
@char0n char0n self-assigned this Apr 14, 2021
@char0n char0n mentioned this issue Apr 14, 2021
Closed
8 tasks
char0n added a commit that referenced this issue Apr 16, 2021
@char0n
feat(ns-openapi-3-1): implement refractor plugin for inheritance
4c83162 
This plugin transforms all Schema Elements in advance
and assigns information about inherited JSON Schema dialect to Schema Element.
One only has to inspect $schema property of Schema Element or
look into inherited meta property (inherited$schema) to determine
actual dialect of the Schema Element.

Closes #362
@char0n char0n mentioned this issue Apr 16, 2021
Merged
@char0n
Copy link
Member Author

char0n commented Apr 16, 2021

This functionality was finally implemented as refractor plugin as all other options proved to be significantly more complex.

char0n added a commit that referenced this issue Apr 16, 2021
@char0n
fix(ns-openapi-3-1): fix bug in embedded-resources- plugin
6282958 
Refs #362
char0n added a commit that referenced this issue Apr 16, 2021
@char0n
feat(ns-openapi-3-1): implement refractor plugin for inheritance
9171db9 
This plugin transforms all Schema Elements in advance
and assigns information about inherited JSON Schema dialect to Schema Element.
One only has to inspect $schema property of Schema Element or
look into inherited meta property (inherited$schema) to determine
actual dialect of the Schema Element.

Closes #362
char0n added a commit that referenced this issue Apr 16, 2021
@char0n
fix(ns-openapi-3-1): fix bug in embedded-resources- plugin
2809390 
Refs #362
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@char0n char0n

Labels
ApiDOM enhancement New feature or request OpenAPI 3.1
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(ns-openapi-3-1): implement refractor plugin for inheritance swagger-api/apidom
1 participant
@char0n