Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use tree-sitter as underlining parser #35

Closed
6 of 7 tasks
char0n opened this issue Jul 23, 2020 · 2 comments
Closed
6 of 7 tasks

Use tree-sitter as underlining parser #35

char0n opened this issue Jul 23, 2020 · 2 comments
Assignees
@char0n
Labels
ApiDOM enhancement New feature or request OpenAPI 3.1
Milestone
M6

Comments

@char0n
Copy link
Member

char0n commented Jul 23, 2020 •
edited
Loading

Start implementations with creating standardized AST via stampit specification and continue with transformer of CST -> AST. This will allows us to continue using current babel/graphql inspired traversal mechanism of ours. I'd need to change an architecture of code to reflect the possibility to plug a custom CST -> AST transformers if somebody would like to create a competing implementation using ANTLR4 or other parser generator.

This is direct follow up of https://github.com/swagger-api/oss-planning/issues/132

  • implement CST -> AST transformer
  • implement error accumulation mechanism
  • replace json-ast for tree-sitter
  • remove comments support
  • error handling
  • browser version of build fragments (web-tree-sitter)
  • buildable ApiDOM demo build from linking current monorepo packages
@char0n char0n added enhancement New feature or request OpenAPI 3.1 ApiDOM labels Jul 23, 2020
@char0n char0n added this to the M5 milestone Jul 23, 2020
@char0n char0n self-assigned this Jul 23, 2020
char0n added a commit that referenced this issue Jul 27, 2020
@char0n
feat: introduce our own AST layer
b267cf0 
Refs #35
@char0n char0n mentioned this issue Jul 27, 2020
Merged
char0n added a commit that referenced this issue Jul 27, 2020
@char0n
feat: introduce our own AST layer
c3c137e 
Refs #35
char0n added a commit that referenced this issue Jul 31, 2020
@char0n
feat: add CST to AST transformer for tree-sitter
918baf4 
Refs #35
@char0n char0n mentioned this issue Jul 31, 2020
Merged
char0n added a commit that referenced this issue Jul 31, 2020
@char0n
feat: add CST to AST transformer for tree-sitter
9d3f03c 
Refs #35
char0n added a commit that referenced this issue Aug 5, 2020
@char0n
feat(AST): incorporate missing nodes into AST
0122d35 
Refs #35
@char0n char0n mentioned this issue Aug 5, 2020
Merged
char0n added a commit that referenced this issue Aug 6, 2020
@char0n
feat(AST): incorporate missing nodes into AST
65a75b8 
Refs #35
char0n added a commit that referenced this issue Aug 6, 2020
@char0n
feat(ast): make errors and missing nodes part of AST
c6c230d 
Refs #35
@char0n char0n mentioned this issue Aug 6, 2020
Merged
char0n added a commit that referenced this issue Aug 6, 2020
@char0n
test(cst): add test for having error node as root node
8703814 
Refs #35
char0n added a commit that referenced this issue Aug 6, 2020
@char0n
feat(ast): make errors and missing nodes part of AST
6142fab 
Refs #35
char0n added a commit that referenced this issue Aug 6, 2020
@char0n
test(cst): add test for having error node as root node
43d167c 
Refs #35
char0n added a commit that referenced this issue Aug 11, 2020
@char0n
refactor: replace json-ast with tree-sitter
f81a431 
This commit replaces underlying json-ast parser with
tree-sitter.

Refs #35
@char0n char0n mentioned this issue Aug 11, 2020
Merged
char0n added a commit that referenced this issue Aug 11, 2020
@char0n
refactor: replace json-ast with tree-sitter
fbe723a 
This commit replaces underlying json-ast parser with
tree-sitter.

Refs #35
char0n added a commit that referenced this issue Aug 11, 2020
@char0n
feat: add support for errors and missing literals
ddae183 
Refs #35
@char0n char0n mentioned this issue Aug 11, 2020
Merged
char0n added a commit that referenced this issue Aug 11, 2020
@char0n
feat: add support for errors and missing literals
3dc5c3a 
Refs #35
@char0n
Copy link
Member Author

char0n commented Aug 13, 2020

web-tree-sitter browser integration issues:

tree-sitter/tree-sitter#681
tree-sitter/tree-sitter#466
tree-sitter/tree-sitter#559
tree-sitter/tree-sitter#569
tree-sitter/tree-sitter#570
https://stackoverflow.com/questions/58599271/i-cannot-understand-module-not-found-error-cant-resolve-fs

Possible workaround:

https://developer.aliyun.com/mirror/npm/package/monaco-tree-sitter

@frantuma frantuma modified the milestones: M5, M6 Aug 14, 2020
char0n added a commit that referenced this issue Aug 14, 2020
@char0n
feat(openapi-3.1-adapter): add support for browser build fragments
800f658 
Refs #35
@char0n char0n mentioned this issue Aug 14, 2020
Merged
char0n added a commit that referenced this issue Aug 14, 2020
@char0n
feat(openapi-3.1-adapter): add support for browser build fragments
d5cbd78 
Refs #35
char0n added a commit that referenced this issue Aug 14, 2020
@char0n
feat(openapi-3.1-adapter): add support for browser build fragments
30782a0 
Refs #35
char0n added a commit that referenced this issue Aug 14, 2020
@char0n
chore(apidom): create demo using dist build fragments
983506a 
Refs #35
@char0n char0n mentioned this issue Aug 14, 2020
Merged
char0n added a commit that referenced this issue Aug 14, 2020
@char0n
chore(apidom): create demo using dist build fragments
e203bba 
Refs #35
char0n added a commit that referenced this issue Aug 17, 2020
@char0n
chore: add apidom webpack demo experiments
634042d 
Refs #35
@char0n char0n mentioned this issue Aug 17, 2020
Merged
@char0n
Copy link
Member Author

char0n commented Aug 17, 2020

Closing this issue as all related tasks have been implemented.

@char0n char0n closed this as completed Aug 17, 2020
char0n added a commit that referenced this issue Aug 17, 2020
@char0n
chore: add apidom webpack demo experiments
e2323d0 
Refs #35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@char0n char0n

Labels
ApiDOM enhancement New feature or request OpenAPI 3.1
Projects
None yet
Milestone
M6
Development

No branches or pull requests
2 participants
@char0n @frantuma