fix(ns-openapi-3-1): fix bugs in Schema Object refracting

Closes #337
swagger-api · Apr 9, 2021 · e9e0cd0 · e9e0cd0
1 parent 88cd7e1
commit e9e0cd0
Show file tree

Hide file tree

Showing 4 changed files with 20 additions and 18 deletions.
diff --git a/...dom-ns-openapi-3-1/src/refractor/visitors/open-api-3-1/schema/DependentRequiredVisitor.ts b/...dom-ns-openapi-3-1/src/refractor/visitors/open-api-3-1/schema/DependentRequiredVisitor.ts
@@ -1,15 +1,17 @@
 import stampit from 'stampit';
-import { ArrayElement } from 'apidom';
+import { ObjectElement, BREAK } from 'apidom';
 
 import FallbackVisitor from '../../FallbackVisitor';
 import { appendMetadata } from '../../../metadata';
 
 const DependentRequiredVisitor = stampit(FallbackVisitor, {
   methods: {
-    ArrayElement(arrayElement: ArrayElement) {
-      this.element = arrayElement.clone();
+    ObjectElement(objectElement: ObjectElement) {
+      this.element = objectElement.clone();
 
       appendMetadata(['json-schema-dependentRequired'], this.element);
+
+      return BREAK;
     },
   },
 });

diff --git a/...kages/apidom-ns-openapi-3-1/src/refractor/visitors/open-api-3-1/schema/ExamplesVisitor.ts b/...kages/apidom-ns-openapi-3-1/src/refractor/visitors/open-api-3-1/schema/ExamplesVisitor.ts
@@ -1,5 +1,5 @@
 import stampit from 'stampit';
-import { ArrayElement } from 'apidom';
+import { ArrayElement, BREAK } from 'apidom';
 
 import FallbackVisitor from '../../FallbackVisitor';
 import { appendMetadata } from '../../../metadata';
@@ -10,6 +10,8 @@ const ExamplesVisitor = stampit(FallbackVisitor, {
       this.element = arrayElement.clone();
 
       appendMetadata(['json-schema-examples'], this.element);
+
+      return BREAK;
     },
   },
 });

diff --git a/...kages/apidom-ns-openapi-3-1/src/refractor/visitors/open-api-3-1/schema/RequiredVisitor.ts b/...kages/apidom-ns-openapi-3-1/src/refractor/visitors/open-api-3-1/schema/RequiredVisitor.ts
@@ -1,5 +1,5 @@
 import stampit from 'stampit';
-import { ArrayElement } from 'apidom';
+import { ArrayElement, BREAK } from 'apidom';
 
 import FallbackVisitor from '../../FallbackVisitor';
 import { appendMetadata } from '../../../metadata';
@@ -10,6 +10,8 @@ const RequiredVisitor = stampit(FallbackVisitor, {
       this.element = arrayElement.clone();
 
       appendMetadata(['json-schema-required'], this.element);
+
+      return BREAK;
     },
   },
 });

diff --git a/apidom/packages/apidom-ns-openapi-3-1/src/refractor/visitors/open-api-3-1/schema/index.ts b/apidom/packages/apidom-ns-openapi-3-1/src/refractor/visitors/open-api-3-1/schema/index.ts
@@ -1,21 +1,17 @@
 import stampit from 'stampit';
-import { ObjectElement, BREAK } from 'apidom';
+import { always } from 'ramda';
 
 import SchemaElement from '../../../../elements/Schema';
 import FallbackVisitor from '../../FallbackVisitor';
-import SpecificationVisitor from '../../SpecificationVisitor';
+import FixedFieldsVisitor from '../../generics/FixedFieldsVisitor';
 
-const SchemaVisitor = stampit(SpecificationVisitor, FallbackVisitor, {
-  methods: {
-    ObjectElement(objectElement: ObjectElement) {
-      // @ts-ignore
-      const schemaElement = new SchemaElement(objectElement.content);
-
-      this.copyMetaAndAttributes(objectElement, schemaElement);
-
-      this.element = schemaElement;
-      return BREAK;
-    },
+const SchemaVisitor = stampit(FixedFieldsVisitor, FallbackVisitor, {
+  props: {
+    specPath: always(['document', 'objects', 'Schema']),
+    canSupportSpecificationExtensions: true,
+  },
+  init() {
+    this.element = new SchemaElement();
   },
 });