-
Notifications
You must be signed in to change notification settings - Fork 167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve server onboarding #1095
base: main
Are you sure you want to change the base?
Conversation
Thanks a lot! CI is failing, can you please take a look? |
Can't reproduce this locally, so I'm counting on the failure being a Docker Compose file version thing. (Newer versions of Docker Compose largely ignore this file version, which would explain why it Works For Me (tm).) |
Thanks! Btw, I see you changed some of the ports and how hey are exposed. This is a thing we do on purpose as we have many services locally and we want to make sure we expose the ports in a way that don't clash. I think it's worth bringing this back. |
Hmm, I've thought about the ports issue for a bit. To be honest, I don't see a canonical way out there. Ideally, the Docker Compose
I have a branch that fixes the CI issues, but we should first figure out how to orchestrate port opening. |
Motivation
I wanted to play around with the server codebase, but got stuck while following the instructions.
Solution
I tried to fix any problems I found, such as the port numbers in
development.env
not matching the port numbers of the docker compose configs.I also reorganized the docker compose files, deduplicating configuration using
include
syntax. It now exposes PG and Redis ports by default, i.e. thedocker-compose.override.yml
file is no longer needed. The auth token is now set viadocker-compose.docker-image.yml
. The instructions now use the new v2docker compose
syntax.I combined some steps in the
README
that belong together, so that there is a clear sequence of steps:docker compose