Skip to content

server: add a global request timeout - #1118

Draft
svix-jbrown wants to merge 1 commit into
mainfrom
jbrown/timeout-by-default
Draft

server: add a global request timeout#1118
svix-jbrown wants to merge 1 commit into
mainfrom
jbrown/timeout-by-default

Conversation

@svix-jbrown

Copy link
Copy Markdown
Contributor

helps provide backpressure if things are going really south

@svix-jbrown
svix-jbrown requested a review from a team April 21, 2026 23:52
@svix-jbrown
svix-jbrown requested a review from a team as a code owner April 21, 2026 23:52
@github-actions

github-actions Bot commented Apr 21, 2026

Copy link
Copy Markdown
TestsPassed ✅SkippedFailedTime ⏱
Diom CI JUnit307 ran307 passed0 skipped0 failed5m 18s 902ms
TestResultTime ⏱
No test annotations available

@svix-jbrown
svix-jbrown force-pushed the jbrown/timeout-by-default branch from 4abf108 to d6ff7b9 Compare April 21, 2026 23:55
@github-actions

github-actions Bot commented Apr 22, 2026

Copy link
Copy Markdown

Test Coverage: 79.95%

Artifact download

@svix-jbrown
svix-jbrown force-pushed the jbrown/timeout-by-default branch from d6ff7b9 to 5efa02e Compare April 22, 2026 00:15
@svix-jplatte

Copy link
Copy Markdown
Member

This PR will conflict with my next one for error types. If CI wasn't failing, I'd probably just approve and merge and deal with it myself. Since it isn't, maybe it makes sense to wait for my PR and rebase this one after? It will change things a fair bit, but shouldn't be too annoying.

@svix-jplatte

svix-jplatte commented May 5, 2026

Copy link
Copy Markdown
Member

The error refactor work I mentioned all landed. If you could update this to have fn request_timeout delegate to server_error, just like fn not_ready and fn shutting_down, that would make this fit right in.

@svix-jbrown

Copy link
Copy Markdown
Contributor Author

The error refactor work I mentioned all landed. If you could update this to have fn request_timeout delegate to server_error, just like fn not_ready and fn shutting_down, that would make this fit right in.

Sorry — I realized that because we support long-polling, I need to make this more complicated to exempt the long-polling endpoints. I'll mark as draft until I come up with an ergonomic way to do this

@svix-jbrown
svix-jbrown marked this pull request as draft May 22, 2026 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants