You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This PR will conflict with my next one for error types. If CI wasn't failing, I'd probably just approve and merge and deal with it myself. Since it isn't, maybe it makes sense to wait for my PR and rebase this one after? It will change things a fair bit, but shouldn't be too annoying.
The error refactor work I mentioned all landed. If you could update this to have fn request_timeout delegate to server_error, just like fn not_ready and fn shutting_down, that would make this fit right in.
The error refactor work I mentioned all landed. If you could update this to have fn request_timeout delegate to server_error, just like fn not_ready and fn shutting_down, that would make this fit right in.
Sorry — I realized that because we support long-polling, I need to make this more complicated to exempt the long-polling endpoints. I'll mark as draft until I come up with an ergonomic way to do this
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
helps provide backpressure if things are going really south