Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: migrate to upstream sax #2017

Merged
merged 1 commit into from
May 28, 2024
Merged

chore: migrate to upstream sax #2017

merged 1 commit into from
May 28, 2024

Conversation

SethFalco
Copy link
Member

Migrates from our maintained unmaintained fork of sax-js to upstream.

While sax-js is not actively maintained, it has received some updates which has allowed it to catch up with our fork, and has more bug fixes in it. I've also made contributions to sax-js myself to get here.

There is one change we needed that was not merged upstream, but instead we apply a patch via Yarn in this repository. This is acceptable in this case as the change only impacts the browser bundle, which is our job to generate, and contains the change to lib/sax.js in the following commit:

Related

@SethFalco SethFalco merged commit f604c69 into svg:main May 28, 2024
10 checks passed
@SethFalco SethFalco deleted the chore/sax branch May 28, 2024 07:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error in parsing SVG: Unexpected end
1 participant