Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migrates from our
maintainedunmaintained fork of sax-js to upstream.While sax-js is not actively maintained, it has received some updates which has allowed it to catch up with our fork, and has more bug fixes in it. I've also made contributions to sax-js myself to get here.
There is one change we needed that was not merged upstream, but instead we apply a patch via Yarn in this repository. This is acceptable in this case as the change only impacts the browser bundle, which is our job to generate, and contains the change to
lib/sax.js
in the following commit:Related