Skip to content

chore(deps): bump yargs from 17.7.3 to 18.1.0 - #89

Closed
ThePlenkov wants to merge 0 commit into
dependabot/bun/website/astrojs/starlight-0.41.7from
dependabot/bun/yargs-18.1.0
Closed

ThePlenkov wants to merge 0 commit into
dependabot/bun/website/astrojs/starlight-0.41.7from
dependabot/bun/yargs-18.1.0

Conversation

@ThePlenkov

@ThePlenkov ThePlenkov commented Aug 18, 2026 •

Copy link
Copy Markdown
Contributor

User description

Replacement for #72/#81 (closed during stack restructure). yargs 17.7.3 → 18.1.0 in packages/cli.

Note: @types/yargs remains at ^17.0.33 — this is the latest available version (17.0.35). yargs 18 does not ship types for its main entry, and @types/yargs has no 18.x release. The version mismatch is inherent to yargs 18 and unresolvable until @types/yargs publishes an 18.x version.

Generated with Devin


CodeAnt-AI Description

Update the CLI argument parser to yargs 18.1.0

What Changed

  • The CLI now uses yargs 18.1.0 for command-line argument parsing
  • Existing CLI behavior and TypeScript support remain unchanged

Impact

✅ CLI runs on the current yargs release
✅ Access to yargs 18 updates and fixes

💡 Usage Guide

Checking Your Pull Request

Every time you make a pull request, our system automatically looks through it. We check for security issues, mistakes in how you're setting up your infrastructure, and common code problems. We do this to make sure your changes are solid and won't cause any trouble later.

Talking to CodeAnt AI

Got a question or need a hand with something in your pull request? You can easily get in touch with CodeAnt AI right here. Just type the following in a comment on your pull request, and replace "Your question here" with whatever you want to ask:

@codeant-ai ask: Your question here

This lets you have a chat with CodeAnt AI about your pull request, making it easier to understand and improve your code.

Example

@codeant-ai ask: Can you suggest a safer alternative to storing this secret?

Preserve Org Learnings with CodeAnt

You can record team preferences so CodeAnt AI applies them in future reviews. Reply directly to the specific CodeAnt AI suggestion (in the same thread) and replace "Your feedback here" with your input:

@codeant-ai: Your feedback here

This helps CodeAnt AI learn and adapt to your team's coding style and standards.

Example

@codeant-ai: Do not flag unused imports.

Retrigger review

Ask CodeAnt AI to review the PR again, by typing:

@codeant-ai: review

Check Your Repository Health

To analyze the health of your code repository, visit our dashboard at https://app.codeant.ai. This tool helps you identify potential issues and areas for improvement in your codebase, ensuring your repository maintains high standards of code health.


Summary by cubic

Upgrades yargs in packages/cli from 17.7.3 to 18.1.0 to keep the CLI current. This major bump updates yargs-parser to 22 and cliui to 9, which can subtly change argument parsing and help formatting.

  • Verify command parsing (booleans, arrays, aliases, unknown args, -- passthrough, dot-notation) still matches expected behavior.
  • Check help/usage output and wrapping on narrow terminals (string-width@8).
  • TypeScript: keep @types/yargs@^17 (no 18.x available); builds and editor tooling should continue to pass with existing typings.

Written for commit c922513. Summary will update on new commits.

Review in cubic

@codeant-ai

codeant-ai Bot commented Aug 18, 2026 •

Copy link
Copy Markdown

🤖 CodeAnt AI — Review Status

Status Commit Started (UTC) Finished (UTC)
✅ Reviewed your PR 34136eb Aug 18, 2026 · 12:36 12:36

@baz-reviewer

baz-reviewer Bot commented Aug 18, 2026

Copy link
Copy Markdown

Merger

Waiting for CI and review to complete.

Commit 34136eb · Updated 2026-08-18 12:36 UTC

Review this PR on Baz | Customize your next review

@codeant-ai codeant-ai Bot added the size:XS This PR changes 0-9 lines, ignoring generated files label Aug 18, 2026
@coderabbitai

coderabbitai Bot commented Aug 18, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@ThePlenkov, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 6 minutes

Limit details: You’ve used all 3 included reviews currently available under your plan.

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 7c5ef243-8ee2-4b3c-941a-49d217c551d7

📥 Commits

Reviewing files that changed from the base of the PR and between 06ec9f2 and 34136eb.

⛔ Files ignored due to path filters (1)
  • bun.lock is excluded by !**/*.lock
📒 Files selected for processing (1)
  • packages/cli/package.json

Comment @coderabbitai help to get the list of available commands.

@codacy-production

Copy link
Copy Markdown

Up to standards ✅

🟢 Issues 0 issues

Results:
0 new issues

View in Codacy

AI Reviewer: first review requested successfully. AI can make mistakes. Always validate suggestions.

Run reviewer

TIP This summary will be updated as you push new changes.

@amazon-q-developer amazon-q-developer Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The dependency upgrade from yargs 17.7.3 to 18.1.0 has been correctly applied. The package.json and lockfile changes are mechanically sound. The type mismatch between @types/yargs@^17 and yargs@^18 is acknowledged and expected until @types/yargs publishes v18 types.

Given this is a major version upgrade, ensure thorough testing of all CLI commands to verify argument parsing, boolean flags, array handling, help output formatting, and any custom yargs configurations before merging.


You can now have the agent implement changes and create commits directly on your pull request's source branch. Simply comment with /q followed by your request in natural language to ask the agent to make changes.

@qodo-code-review

Copy link
Copy Markdown

PR Summary by Qodo

Bump CLI yargs dependency to 18.1.0

⚙️ Configuration changes 🕐 Less than 5 minutes

Grey Divider

AI Description

• Upgrade CLI argument parsing dependency from yargs 17.7.3 to 18.1.0.
• Refresh the Bun lockfile for yargs 18's transitive dependency graph.
• Retain yargs 17 typings because no 18.x typings release exists.
High-Level Assessment

The direct dependency upgrade with a regenerated Bun lockfile is the appropriate approach. Keeping @types/yargs on 17.x is necessary because no compatible 18.x typings package is currently published.

Files changed (2) +27 / -3

Other (2) +27 / -3
bun.lockResolve yargs 18 and updated transitive dependencies +26/-2

Resolve yargs 18 and updated transitive dependencies

• Updates the CLI workspace resolution to yargs 18.1.0. Regenerates related cliui, string-width, yargs-parser, ANSI, emoji, and East Asian width dependency entries.

bun.lock

package.jsonUpgrade the CLI yargs dependency +1/-1

Upgrade the CLI yargs dependency

• Raises the CLI's yargs dependency range from ^17.7.3 to ^18.1.0 while retaining the existing @types/yargs version.

packages/cli/package.json

@ThePlenkov
ThePlenkov force-pushed the dependabot/bun/website/astrojs/starlight-0.41.7 branch from 06ec9f2 to c922513 Compare August 18, 2026 12:37

@codacy-production codacy-production Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR upgrades a core CLI dependency to a new major version. Although the project remains up to standards according to automated analysis, the upgrade lacks accompanying verification for critical CLI functionality like argument parsing and help output formatting.

There is an intentional discrepancy between the library and its type definitions due to the unavailability of updated types. While this is noted in the PR intent, it remains a risk for build stability and runtime compatibility that should be addressed through rigorous testing before merging.

About this PR

  • The discrepancy between the library and its type definitions may lead to build failures or runtime issues if the underlying API has diverged in ways not captured by the older type definitions.
  • Performing a major version upgrade of a core dependency without providing evidence of verification or updated test coverage increases the risk of regressions in CLI functionality.

Test suggestions

  • Verify CLI argument parsing (booleans, arrays, and aliases) still functions correctly after the major version bump.
  • Check that CLI help output and line wrapping (using string-width@8) remain properly formatted.
  • Confirm that TypeScript builds continue to pass despite the major version discrepancy between yargs and @types/yargs.
Prompt proposal for missing tests
Consider implementing these tests if applicable:
1. Verify CLI argument parsing (booleans, arrays, and aliases) still functions correctly after the major version bump.
2. Check that CLI help output and line wrapping (using string-width@8) remain properly formatted.
3. Confirm that TypeScript builds continue to pass despite the major version discrepancy between yargs and @types/yargs.

TIP Improve review quality by adding custom instructions
TIP How was this review? Give us feedback

@ThePlenkov ThePlenkov closed this Aug 18, 2026
@ThePlenkov
ThePlenkov force-pushed the dependabot/bun/yargs-18.1.0 branch from 34136eb to c922513 Compare August 18, 2026 12:37
@sonarqubecloud

Copy link
Copy Markdown

@qodo-code-review

Copy link
Copy Markdown

Code Review by Qodo

🐞 Bugs (0) 📘 Rule violations (0) 📎 Requirement gaps (0)

Grey Divider

Great, no issues found!

Qodo reviewed your code and found no material issues that require review

Grey Divider

Tip of the day
💡 Did you know, you can keep summaries lean with Finding overflow, which tucks the rest behind 'View more'

More tips ↗ | Customize Qodo ↗ | Qodo docs ↗

Grey Divider

Qodo Logo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XS This PR changes 0-9 lines, ignoring generated files

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant