Skip to content

chore: upgrade nx 21.6.11 → 23.1.1, fix CI nx version #59

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ThePlenkov merged 1 commit into from
Aug 13, 2026
Merged

chore: upgrade nx 21.6.11 → 23.1.1, fix CI nx version #59

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ jobs:
- run: bun install --frozen-lockfile --ignore-scripts
- uses: nrwl/nx-set-shas@3e9ad7370203c1e93d109be57f3b72eb0eb511b1 # v4

- run: bunx nx@21.0.0 affected -t build
- run: bunx nx@21.0.0 affected -t lint test
- run: bunx nx@21.0.0 fix-ci
- run: nx affected -t build
- run: nx affected -t lint test
- run: nx fix-ci
Comment on lines +32 to +34

@codacy-production codacy-production Bot Aug 13, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔴 HIGH RISK

The nx command will not be found in the runner's PATH. Use bunx nx to execute the local version.

Try running the following prompt in your coding agent:

Prepend bunx to all nx commands in .github/workflows/ci.yml (lines 32-34) to ensure they use the local version installed in node_modules.

Comment on lines +32 to +34

@qodo-code-review qodo-code-review Bot Aug 13, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Action required

1. Ci can't find nx 🐞 Bug ☼ Reliability

The CI workflow now runs nx ... directly, but the job does not add node_modules/.bin to PATH or
use bunx/bun run, so the steps can fail with nx: command not found even after bun install.
This prevents build/lint/test from running in CI.
Agent Prompt 
## Issue description
CI invokes `nx` directly in `.github/workflows/ci.yml`, but the workflow does not ensure local binaries from `node_modules/.bin` are on `PATH`. This can cause `nx: command not found` and fail the job.

## Issue Context
The workflow installs dependencies with `bun install --frozen-lockfile`, but subsequent `run:` steps execute in a plain shell context.

## Fix
Update the workflow to execute Nx through Bun so it reliably resolves the local devDependency binary:
- Replace `nx ...` with `bunx nx ...` (preferred, keeps “use local nx” intent), or
- Replace with `bun run <script>` equivalents, or
- Export `PATH=$GITHUB_WORKSPACE/node_modules/.bin:$PATH` before calling `nx`.

## Fix Focus Areas
- .github/workflows/ci.yml[26-35]

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools

if: always()
Loading
Loading