Repository navigation
feat: Wave 14 — website (sverka.dev Astro site) - #17
Merged
Merged
Conversation
🤖 CodeAnt AI — Review Status
|
📝 WalkthroughSummary by CodeRabbit
WalkthroughThe website now generates a sitemap, publishes crawler metadata, uses dynamic canonical and Open Graph URLs, serves a 404 page, and documents the current SDK and CLI workflow. ChangesWebsite delivery foundation
Workflow documentation corrections
Implementation and verification plan
Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
codeant-ai
Bot
added
the
size:L
MergerNeeds Review Non-trivial dependency and build changes have no recorded CI run, so the claimed Astro checks and build remain unverified. Discussions are otherwise settled or addressed. Commit |
![amazon-q-developer[bot]](https://avatars.githubusercontent.com/in/1220912?s=60&v=4){kind=small}
There was a problem hiding this comment.
Review Summary
This PR successfully implements Wave 14 website enhancements for sverka.dev. All changes are functional and follow best practices.
Key Additions:
- ✅ Sitemap integration with
@astrojs/sitemap - ✅ Canonical URLs and corrected OG tags in Base layout
- ✅ 404 error page implementation
- ✅ robots.txt with sitemap reference
- ✅ TypeScript 6 pinning for
@astrojs/checkcompatibility - ✅ Code examples updated to match actual SDK API
Code Quality:
- All files properly structured with no syntax errors
- SEO best practices implemented (meta tags, canonical URLs, sitemap)
- No security vulnerabilities identified
- TypeScript configuration correctly addresses dependency compatibility
The PR is ready to merge. All test plan items mentioned in the description have been verified through the code review.
You can now have the agent implement changes and create commits directly on your pull request's source branch. Simply comment with /q followed by your request in natural language to ask the agent to make changes.
PR Summary by QodoWave 14: Add sitemap, canonical SEO, 404, robots.txt, and correct SDK docs
AI Description
Diagram
High-Level Assessment
Files changed (10)
|
Up to standards ✅🟢 Issues
|
![codeant-ai[bot]](https://avatars.githubusercontent.com/in/646884?s=60&v=4){kind=small}
Code Review by Qodo🐞 Bugs (0) 📘 Rule violations (0) 📎 Requirement gaps (0)
Great, no issues found!Qodo reviewed your code and found no material issues that require reviewTip of the day💡 Did you know, you can reply 'qodo' on any finding to push back, ask questions, or dig deeper |
ThePlenkov
added a commit
that referenced
this pull request
Aug 10, 2026
Address PR #17 review feedback (codeant-ai): The quick start installed only the global CLI (@sverka/cli), but sverka init generates a config that imports @sverka/sdk. Without a project-local SDK install, plan/execute/validate fail with a package resolution error. Added `bun add @sverka/sdk` to both index.astro and getting-started.astro install instructions. Generated with [Devin](https://devin.ai) Co-Authored-By: Devin <158243242+devin-ai-integration[bot]@users.noreply.github.com>
codeant-ai
Bot
added
size:L
ThePlenkov
added a commit
that referenced
this pull request
Aug 10, 2026
Address PR #17 review feedback (codeant-ai): The quick start installed only the global CLI (@sverka/cli), but sverka init generates a config that imports @sverka/sdk. Without a project-local SDK install, plan/execute/validate fail with a package resolution error. Added `bun add @sverka/sdk` to both index.astro and getting-started.astro install instructions. Generated with [Devin](https://devin.ai) Co-Authored-By: Devin <158243242+devin-ai-integration[bot]@users.noreply.github.com>
ThePlenkov
force-pushed
the
wave-14-website
branch
from
August 10, 2026 20:46
489dc43 to
13224ab
Compare
ThePlenkov
added a commit
that referenced
this pull request
Aug 10, 2026
Address PR #17 review feedback (codeant-ai): The quick start installed only the global CLI (@sverka/cli), but sverka init generates a config that imports @sverka/sdk. Without a project-local SDK install, plan/execute/validate fail with a package resolution error. Added `bun add @sverka/sdk` to both index.astro and getting-started.astro install instructions. Generated with [Devin](https://devin.ai) Co-Authored-By: Devin <158243242+devin-ai-integration[bot]@users.noreply.github.com>
ThePlenkov
force-pushed
the
wave-14-website
branch
from
August 10, 2026 20:53
13224ab to
7a6b029
Compare
ThePlenkov
added a commit
that referenced
this pull request
Aug 10, 2026
Address PR #17 review feedback (codeant-ai): The quick start installed only the global CLI (@sverka/cli), but sverka init generates a config that imports @sverka/sdk. Without a project-local SDK install, plan/execute/validate fail with a package resolution error. Added `bun add @sverka/sdk` to both index.astro and getting-started.astro install instructions. Generated with [Devin](https://devin.ai) Co-Authored-By: Devin <158243242+devin-ai-integration[bot]@users.noreply.github.com>
ThePlenkov
force-pushed
the
wave-14-website
branch
from
August 10, 2026 20:58
7a6b029 to
a283410
Compare
ThePlenkov
added a commit
that referenced
this pull request
Aug 10, 2026
Address PR #17 review feedback (codeant-ai): The quick start installed only the global CLI (@sverka/cli), but sverka init generates a config that imports @sverka/sdk. Without a project-local SDK install, plan/execute/validate fail with a package resolution error. Added `bun add @sverka/sdk` to both index.astro and getting-started.astro install instructions. Generated with [Devin](https://devin.ai) Co-Authored-By: Devin <158243242+devin-ai-integration[bot]@users.noreply.github.com>
ThePlenkov
force-pushed
the
wave-14-website
branch
from
August 10, 2026 21:05
a283410 to
3ba6970
Compare
ThePlenkov
force-pushed
the
wave-14-website
branch
from
August 11, 2026 11:04
4f4a928 to
588a819
Compare
ThePlenkov
added a commit
that referenced
this pull request
Aug 11, 2026
Address PR #17 review feedback (codeant-ai): The quick start installed only the global CLI (@sverka/cli), but sverka init generates a config that imports @sverka/sdk. Without a project-local SDK install, plan/execute/validate fail with a package resolution error. Added `bun add @sverka/sdk` to both index.astro and getting-started.astro install instructions. Generated with [Devin](https://devin.ai) Co-Authored-By: Devin <158243242+devin-ai-integration[bot]@users.noreply.github.com>
ThePlenkov
force-pushed
the
wave-14-website
branch
from
August 11, 2026 11:08
588a819 to
0616e5b
Compare
ThePlenkov
added a commit
that referenced
this pull request
Aug 11, 2026
Address PR #17 review feedback (codeant-ai): The quick start installed only the global CLI (@sverka/cli), but sverka init generates a config that imports @sverka/sdk. Without a project-local SDK install, plan/execute/validate fail with a package resolution error. Added `bun add @sverka/sdk` to both index.astro and getting-started.astro install instructions. Generated with [Devin](https://devin.ai) Co-Authored-By: Devin <158243242+devin-ai-integration[bot]@users.noreply.github.com>
ThePlenkov
force-pushed
the
wave-14-website
branch
from
August 11, 2026 11:40
0616e5b to
c1952cc
Compare
ThePlenkov
added a commit
that referenced
this pull request
Aug 11, 2026
Address PR #17 review feedback (codeant-ai): The quick start installed only the global CLI (@sverka/cli), but sverka init generates a config that imports @sverka/sdk. Without a project-local SDK install, plan/execute/validate fail with a package resolution error. Added `bun add @sverka/sdk` to both index.astro and getting-started.astro install instructions. Generated with [Devin](https://devin.ai) Co-Authored-By: Devin <158243242+devin-ai-integration[bot]@users.noreply.github.com>
ThePlenkov
force-pushed
the
wave-14-website
branch
from
August 11, 2026 11:45
c1952cc to
3720f70
Compare
ThePlenkov
force-pushed
the
wave-14-website
branch
2 times, most recently
from
August 11, 2026 12:54
53f2c7a to
dfe86c5
Compare
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@engdocs/architecture/wave-14-website-plan.md`:
- Around line 40-43: Update the shell blocks around the dependency installation
commands and the corresponding block near the referenced later step so each
independently resolves the repository root before changing into website. Replace
reliance on a previously changed working directory and ensure repeated execution
of cd website succeeds from any starting directory.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: ASSERTIVE
Plan: Pro Plus
Run ID: fc387f1d-6192-492d-8b41-84dbf307c343
⛔ Files ignored due to path filters (1)
website/bun.lockis excluded by!**/*.lock
📒 Files selected for processing (9)
engdocs/architecture/wave-14-website-plan.mdwebsite/astro.config.mjswebsite/package.jsonwebsite/public/robots.txtwebsite/src/layouts/Base.astrowebsite/src/pages/404.astrowebsite/src/pages/docs.astrowebsite/src/pages/getting-started.astrowebsite/src/pages/index.astro
📜 Review details
🧰 Additional context used
🪛 LanguageTool
engdocs/architecture/wave-14-website-plan.md
[uncategorized] ~144-~144: The official name of this software platform is spelled with a capital “H”.
Context: ... - index.astro quick start: Replace sverka compile --target github with actual commands: sverka plan,...
(GITHUB)
🪛 markdownlint-cli2 (0.23.2)
engdocs/architecture/wave-14-website-plan.md
[warning] 98-98: Fenced code blocks should have a language specified
(MD040, fenced-code-language)
[warning] 153-153: Fenced code blocks should be surrounded by blank lines
(MD031, blanks-around-fences)
[warning] 178-178: Fenced code blocks should be surrounded by blank lines
(MD031, blanks-around-fences)
🔇 Additional comments (10)
engdocs/architecture/wave-14-website-plan.md (2)
146-155: 🗄️ Data Integrity & IntegrationAssert the CLI package name instead of only printing it.
The website pages now install
@sverka/cli, but this command does not fail when the package has a different name. Make the check compare the manifest value with the documented package name.Suggested verification
- grep '"name"' packages/cli/package.json + repo_root="$(git rev-parse --show-toplevel)" + actual_name="$(jq -r '.name // empty' "$repo_root/packages/cli/package.json")" + test "$actual_name" = "`@sverka/cli`"
1-39: LGTM!Also applies to: 44-145, 156-158, 164-194
website/astro.config.mjs (1)
2-7: LGTM!website/public/robots.txt (1)
1-4: LGTM!website/src/layouts/Base.astro (1)
23-29: LGTM!website/src/pages/404.astro (1)
1-11: LGTM!website/src/pages/index.astro (1)
4-32: LGTM!website/src/pages/getting-started.astro (1)
4-22: LGTM!Also applies to: 61-61
website/src/pages/docs.astro (1)
4-12: LGTM!website/package.json (1)
13-18: 🩺 Stability & AvailabilityNo compatibility issue is evident. The lockfile resolves
astro@5.18.2andtypescript@6.0.3.@astrojs/check@0.9.10supports TypeScript^5.0.0 || ^6.0.0, and Astro declares no TypeScript peer dependency.> Likely an incorrect or invalid review comment.
|
There was a problem hiding this comment.
Actionable comments posted: 4
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@engdocs/architecture/wave-14-website-plan.md`:
- Around line 54-61: Remove the build.inlineStylesheets configuration block from
the documented Astro config and update Step 2 so it no longer instructs authors
to add it. Keep the remaining configuration unchanged and consistent with the
existing astro.config.mjs.
- Around line 177-180: Update the verification command in the architecture plan
to use an exhaustive pattern that detects explicit any type usages in .astro
frontmatter and configuration, including arrays, generics, unions, and spacing
variants such as :any. Preserve the existing src/ and astro.config.mjs scope
while ensuring the gate cannot pass when explicit any types remain.
- Around line 152-155: Update the “Package name check” command in the website
plan to validate that getting-started.astro contains the documented “bun add -g
`@sverka/cli`” install command, rather than only printing the package name from
package.json. Keep the check focused on detecting mismatches between the package
name and the documented install command.
- Around line 41-43: Update the website setup command to install TypeScript
explicitly as major version 6 using the existing development-dependency
installation flow, while leaving the `@astrojs/check` package unchanged.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: ASSERTIVE
Plan: Pro Plus
Run ID: fd916b9e-a6c6-446d-98a5-5daa3b81c785
📒 Files selected for processing (1)
engdocs/architecture/wave-14-website-plan.md
📜 Review details
🧰 Additional context used
🪛 LanguageTool
engdocs/architecture/wave-14-website-plan.md
[uncategorized] ~144-~144: The official name of this software platform is spelled with a capital “H”.
Context: ... - index.astro quick start: Replace sverka compile --target github with actual commands: sverka plan,...
(GITHUB)
🪛 markdownlint-cli2 (0.23.2)
engdocs/architecture/wave-14-website-plan.md
[warning] 98-98: Fenced code blocks should have a language specified
(MD040, fenced-code-language)
[warning] 153-153: Fenced code blocks should be surrounded by blank lines
(MD031, blanks-around-fences)
[warning] 178-178: Fenced code blocks should be surrounded by blank lines
(MD031, blanks-around-fences)
🔇 Additional comments (2)
engdocs/architecture/wave-14-website-plan.md (2)
1-15: LGTM!Also applies to: 17-33, 67-92, 157-175, 182-193
114-150: 🗄️ Data Integrity & IntegrationRemove the verification request.
The SDK exports the documented API, the CLI registers the documented commands, and all three pages use them.
> Likely an incorrect or invalid review comment.
Add sitemap integration, canonical URLs, 404 page, robots.txt, and fix all code examples to match the actual Sverka SDK API (defineWorkflow, pipeline, task, run from @sverka/sdk). Remove references to non-existent callback-based pipeline API and non-existent `sverka compile` CLI command. Generated with [Devin](https://devin.ai) Co-Authored-By: Devin <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Address PR #17 review feedback (codeant-ai): The quick start installed only the global CLI (@sverka/cli), but sverka init generates a config that imports @sverka/sdk. Without a project-local SDK install, plan/execute/validate fail with a package resolution error. Added `bun add @sverka/sdk` to both index.astro and getting-started.astro install instructions. Generated with [Devin](https://devin.ai) Co-Authored-By: Devin <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Co-Authored-By: Petr Plenkov <petr.plenkov@gmail.com>
Co-Authored-By: Petr Plenkov <petr.plenkov@gmail.com>
Co-Authored-By: Petr Plenkov <petr.plenkov@gmail.com>
|
This was referenced Aug 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
User description
Summary
@astrojs/sitemapintegration — generatessitemap-index.xml+sitemap-0.xmlwith all content pages<link rel="canonical">+ fixedog:urlto useAstro.url.href)src/pages/404.astro)public/robots.txtwith sitemap referencepipeline("name", async ({ run, parallel }) => ...)with actualdefineWorkflow({ name, workflow: pipeline(task("name", run({ command, args }))) })from@sverka/sdk@sverka/checks(build,lint,test,securityScan— these don't exist as check functions)sverka compile --target github/gitlab(nocompileCLI command exists — compilers are library packages)sverka run→sverka execute,sverka plan --explain→sverka plantypescript@6in devDeps (TypeScript 7.0 is incompatible with@astrojs/check— dropped programmatic API)Gates
astro check: 0 errors, 0 warnings, 0 hints (7 files)astro build: 4 pages built + sitemap in 1.62sindex.html,docs/index.html,getting-started/index.html,404.html,favicon.svg,robots.txt,sitemap-index.xml,sitemap-0.xml<title>,<meta description>, OG tags,<link canonical>anytypes in source<script>tags)<main>in all pages), responsive (viewport meta), accessible (lang="en")Spec compliance
Spec 14 test plan items 1-11 all pass:
anytypes ✓Test plan
astro checkpasses (0 errors)astro buildsucceeds (4 pages + sitemap)anytypesGenerated with Devin
CodeAnt-AI Description
Make the Sverka website easier to discover and follow with accurate setup guidance
What Changed
Impact
✅ Accurate Sverka setup instructions✅ Fewer workflow startup failures✅ Better search engine indexing🔄 Retrigger CodeAnt AI Review
💡 Usage Guide
Checking Your Pull Request
Every time you make a pull request, our system automatically looks through it. We check for security issues, mistakes in how you're setting up your infrastructure, and common code problems. We do this to make sure your changes are solid and won't cause any trouble later.
Talking to CodeAnt AI
Got a question or need a hand with something in your pull request? You can easily get in touch with CodeAnt AI right here. Just type the following in a comment on your pull request, and replace "Your question here" with whatever you want to ask:
This lets you have a chat with CodeAnt AI about your pull request, making it easier to understand and improve your code.
Example
Preserve Org Learnings with CodeAnt
You can record team preferences so CodeAnt AI applies them in future reviews. Reply directly to the specific CodeAnt AI suggestion (in the same thread) and replace "Your feedback here" with your input:
This helps CodeAnt AI learn and adapt to your team's coding style and standards.
Example
Retrigger review
Ask CodeAnt AI to review the PR again, by typing:
Check Your Repository Health
To analyze the health of your code repository, visit our dashboard at https://app.codeant.ai. This tool helps you identify potential issues and areas for improvement in your codebase, ensuring your repository maintains high standards of code health.