Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: additional explanation for "protect all flows" #272

Merged
merged 1 commit into from
Apr 15, 2024

Conversation

bhaugeea
Copy link
Contributor

@bhaugeea bhaugeea commented Apr 4, 2024

Mainly adds additional explanation of post login flows, which are not unique to this extension but highly relevant. This additional information would be helpful for new/prospective users like me. Keycloak's own documentation seems to lack a searchable explanation about how brokering bypasses subsequent authentication flow steps, and not only allows but really requires explicit post login flows.

@leona-ya
Copy link

leona-ya commented Apr 14, 2024

I would also add that the registration and reset credentials flow are affected. These are really simple to exploit, so we should mention them explicitly. It's really not very clear that they don't just use the browser flow.

@sventorben sventorben self-assigned this Apr 15, 2024
@sventorben sventorben self-requested a review April 15, 2024 19:38
@sventorben sventorben added the documentation Improvements or additions to documentation label Apr 15, 2024
@sventorben sventorben merged commit cf4d9cb into sventorben:main Apr 15, 2024
11 of 12 checks passed
@sventorben
Copy link
Owner

Thanks for the contribution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants