Use getClientId instead of getName for getting clients' name #136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @danifr |
sventorben
reviewed
Jan 24, 2023
...a/de/sventorben/keycloak/authorization/client/access/role/ClientRoleBasedAccessProvider.java
Outdated
Show resolved
Hide resolved
'Name' field is optional whereas 'client ID' is mandatory
danifr
force-pushed
the
use_getClientId
branch
from
f349538 to
6c3bdf5
Compare
|
Thank you! |
|
Hi Sven-Torben, do you think you can release a new version of this package (v.20.0.X or the version number you consider) including this patch and the other changes that landed in Thank you very much! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi!
When looking at the logs messages:
The client name seems to be empty.
The current version of the authenticator uses
getName()to get the clients' name, but this attribute is optional in Keycloak.I'd suggest changing it by
getClientId()(https://github.com/keycloak/keycloak/blob/main/server-spi/src/main/java/org/keycloak/models/ClientModel.java#L112) that returns the mandatory "client ID" attribute as defined by the user.