Handle accessing keys with a leading period #87
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Why: So that ActiveRecord backend behaves the same as the Simple backend.
gingermusketeer
force-pushed
the
bug/handle-lookups-with-leading-periods
branch
from
eacdbb9
to
696302d
Compare
timfjord
reviewed
Nov 20, 2017
test/active_record_test.rb
Outdated
| test "accessing keys with a leading period" do | ||
| expected_hash = { :bar => 'bar', :baz => 'baz' } | ||
| assert_equal expected_hash, I18n.t('foo') | ||
| assert_equal expected_hash, I18n.t('.foo') |
There was a problem hiding this comment.
What about I18n.t('foo.')? I think it should also return the same
There was a problem hiding this comment.
Good catch, I have added support for that.
|
Thanks, @gingermusketeer. Merged! |
|
@Timsly Any chance of a release with this change included? |
|
Completely forgot to release it. |
|
Many thanks :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why: So that the ActiveRecord backend behaves the same as the Simple backend.