Fix inconsistency with other I18n backends #86
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Why: So that tests can be run in isolation.
Why: So that the ActiveRecord Backend is consistent with the default rails backend.
timfjord
requested changes
Nov 17, 2017
lib/i18n/backend/active_record.rb
Outdated
| @@ -51,6 +51,10 @@ def lookup(locale, key, scope = [], options = {}) | |||
| key = normalize_flat_keys(locale, key, scope, options[:separator]) | |||
| result = Translation.locale(locale).lookup(key) | |||
|
|
|||
| if result.empty? && key == '.' | |||
There was a problem hiding this comment.
Why don't we call this before or instead result = Translation.locale(locale).lookup(key)
Maybe smth like
result = if key == '.'
Translation.locale(locale).all
else
Translation.locale(locale).lookup(key)
endThis way we won't run two queries for . key
|
@gingermusketeer Thanks for your contribution. I've added one comment |
Why: So the database is only hit once for the lookup.
|
@Timsly Thanks for pointing that out. I have made the change you suggested! |
timfjord
approved these changes
Nov 17, 2017
|
Merged! Thanks @gingermusketeer |
gingermusketeer
deleted the
fix-inconsistency-with-other-i18n-backends
branch
|
Thank you!! |
|
Released as |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I18n::Backend::Simplesupports returning all keys by invokingI18n.t('.'). This adds support for this functionality so that it is consistent with the simple backend.I ran into this problem when using different backends across environments in rails.
Hopefully the changes I have made make sense!