Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[@svelteui/core]: add AspectRatio component #400

Merged
merged 3 commits into from
Jun 20, 2023
Merged

[@svelteui/core]: add AspectRatio component #400

merged 3 commits into from
Jun 20, 2023

Conversation

khalibloo
Copy link
Contributor

@khalibloo khalibloo commented Jun 19, 2023 •
edited
Loading

Description

Added AspectRatio component. It works using the padding technique described here https://www.w3schools.com/howto/howto_css_aspect_ratio.asp

image
image

Before submitting the PR, please make sure you do the following

  • Read the Contributing guide
  • Prefix your PR title with [@svelteui/core], [@svelteui/actions], [@svelteui/motion], [@svelteui/core], [core], or [docs].
  • Include a description of the changes made in the PR description and in the commit messages.
  • Include screenshots/videos of the changes made.
  • Verify that the linter and tests are passing, with yarn lint and yarn test or just run yarn prepush.

@BeeMargarida BeeMargarida added enhancement New feature or request component New or changes to components labels Jun 20, 2023
BeeMargarida
BeeMargarida reviewed Jun 20, 2023
View reviewed changes
Copy link
Member

@BeeMargarida BeeMargarida left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! This is a very complete PR, really great! Just left some very small comments.

packages/svelteui-core/src/components/AspectRatio/AspectRatio.d.ts Outdated Show resolved Hide resolved
packages/svelteui-core/src/components/AspectRatio/AspectRatio.svelte Outdated Show resolved Hide resolved
@BeeMargarida BeeMargarida merged commit 343c92f into svelteuidev:main Jun 20, 2023
@BeeMargarida
Copy link
Member

Thank you for this contribution! 🙌

@khalibloo khalibloo deleted the feat/aspect-ratio branch June 20, 2023 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BeeMargarida BeeMargarida BeeMargarida approved these changes

Assignees
No one assigned
Labels
component New or changes to components enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@khalibloo @BeeMargarida