Component/file upload #316
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BeeMargarida
requested changes
Feb 18, 2023
There was a problem hiding this comment.
Thank you so much for this contribution!
There seems to be a bug in the functionality: using the first story, after I had a file and then remove it, I can't upload the same file again, only another. Not sure what the problem is at first sight.
Except this bug, In terms of functionality it all seems 👌, but the style is still not there. However that we can tweak later, I can make those changes after merging this
Also, as a note, you can make commits with our recommended structure running the command yarn cm or yarn cm:noadd
packages/svelteui-core/src/components/FileUpload/FileUpload.svelte
Outdated
Show resolved
Hide resolved
packages/svelteui-core/src/components/FileUpload/FileUpload.svelte
Outdated
Show resolved
Hide resolved
packages/svelteui-core/src/components/FileUpload/FileUpload.svelte
Outdated
Show resolved
Hide resolved
packages/svelteui-core/src/components/FileUpload/FileUpload.svelte
Outdated
Show resolved
Hide resolved
packages/svelteui-core/src/components/FileUpload/FileUpload.styles.ts
Outdated
Show resolved
Hide resolved
BeeMargarida
added
enhancement
|
|
BeeMargarida
approved these changes
Feb 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add New File upload control