Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow trailing spaces #3

Merged
merged 2 commits into from
Jul 7, 2023
Merged

Allow trailing spaces #3

merged 2 commits into from
Jul 7, 2023

Conversation

jarda-svoboda
Copy link
Member

@jarda-svoboda jarda-svoboda commented Jul 7, 2023

This PR slightly changes behavior of the Default parser's placeholders. In previous versions, all trailing spaces have been trimmed. This change will result in this behavior:

{{ undefined_key; default: Default value; }}
// => 'Default value'
{{ undefined_key; default: Default value ; }}
// => 'Default value '
{{undefined_key; default: Default value}}
// => 'Default value'
{{ undefined_key; default: Default value }}
// => 'Default value '
  • Edit whitespace trimming
  • Update tests

Closes sveltekit-i18n/lib#111

@jarda-svoboda jarda-svoboda added the Default parser Issue related to the Default parser label Jul 7, 2023
@jarda-svoboda jarda-svoboda merged commit 4a0920f into master Jul 7, 2023
3 checks passed
@jarda-svoboda jarda-svoboda deleted the feat/trailing-spaces branch July 7, 2023 21:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Default parser Issue related to the Default parser
Projects
None yet
1 participant