fix: "fix: dynamicImport svelte config #47" #49
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 27, 2021
|
can this PR be merged as it currently prevents anyone from using latest svelte-kit with windicss (using vite adapter) ? not want to be annoying, just asking... |
Merged
|
Thank you for starting this, unfortunately it required additional changes for testing. I went ahead and implemented it here #54 please let me know if that works for you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I solved this bug #47 by refacting the project to esm.
This change must use
tsupto build, esbuild cannot deal with some compatibility problems between cjs and esm, so I replace it.you can verify it with running https://github.com/SOVLOOKUP/midway-svelte