fix: update warning codes for svelte5 #1044
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dominikg
commented
Dec 11, 2024
| @@ -114,6 +114,7 @@ export function enhanceCompileError(err, originalCode, preprocessors) { | |||
|
|
|||
| // Handle incorrect CSS preprocessor usage | |||
| if (err.code === 'css-syntax-error') { | |||
There was a problem hiding this comment.
@dummdidumm whats the new way to identify css syntax errors? i looked but didn't find the corrosponding code in svelte5
There was a problem hiding this comment.
There are two things you can look for:
- any error starting with
css_- right now it'scss_expected_identifier,css_selector_invalidandcss_empty_declaration - more general errors:
expected_tokenandunexpected_eof- though these could also happen in other parts outside the style sheet (not sure if that is a problem)
There was a problem hiding this comment.
added with generic startswith css_ , technically this could introduce false positives for users who don't use a css preprocessor, so if we want to play it conservative, we'd have to use a hardcoded list at the cost of that getting out of date if new codes are added.
dummdidumm
approved these changes
Dec 12, 2024
Merged
dominikg
added a commit
that referenced
this pull request
Dec 12, 2024
* fix: update warning codes for svelte5 * fix(audit): bump nanoid * fix: replace css error code detection so that it works for svelte5 * chore: update changeset (cherry picked from commit e41edff)
dominikg
added a commit
that referenced
this pull request
Dec 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
needs to be backported to v-p-s@4 too